public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Andrew Lunn <andrew@lunn•ch>
To: Petr Kulhavy <petr@barix•com>
Cc: netdev@vger•kernel.org
Subject: Re: davinci-mdio: failing to connect to PHY
Date: Mon, 4 Apr 2016 15:58:13 +0200	[thread overview]
Message-ID: <20160404135813.GA25131@lunn.ch> (raw)
In-Reply-To: <5702710A.5010804@barix.com>

On Mon, Apr 04, 2016 at 03:50:02PM +0200, Petr Kulhavy wrote:
> 
> 
> On 04.04.2016 14:31, Andrew Lunn wrote:
> >Hi Petr
> >
> >You might want to take a look at:
> >
> >http://lxr.free-electrons.com/source/drivers/net/ethernet/ti/davinci_mdio.c#L137
> >
> >It seems to be asking the hardware about the phy mask.
> >
> >    Andrew
> 
> Hi Andrew,
> 
> thanks a lot for the link. In the meantime I've understood the issue
> better. It is due to the fact that the PHY is pin-strapped to
> address 1 and broadcast (at address 0) is  enabled. The Micrel
> driver's config_init() disables the broadcast and the PHY stops
> responding, which causes the troubles. The kernel 3.17 didn't
> disable the broadcast and therefore it worked.
> 
> I'm wondering how to solve or workaround this...

One option is in your device tree is to explicitly list the phy on
your mdio bus. Something like:

&mdio {
        status = "okay";

        ethphy0: ethernet-phy@1 {
                reg = <1>;
        };
};

This alone might be sufficient. If not, you need to reference the phy
via a phandle in the ethernet node.


&eth0 {
        status = "okay";
        phy-handle = <&ethphy0>;
};

	Andrew

next prev parent reply	other threads:[~2016-04-04 13:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04  8:18 davinci-mdio: failing to connect to PHY Petr Kulhavy
2016-04-04 12:31 ` Andrew Lunn
2016-04-04 13:50   ` Petr Kulhavy
2016-04-04 13:58     ` Andrew Lunn [this message]
2016-04-04 14:01       ` Petr Kulhavy
  -- strict thread matches above, loose matches on Subject: below --
2016-04-01 15:24 Petr Kulhavy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160404135813.GA25131@lunn.ch \
    --to=andrew@lunn$(echo .)ch \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=petr@barix$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox