From: Andrew Lunn <andrew@lunn•ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kernel@savoirfairelinux•com,
"David S. Miller" <davem@davemloft•net>,
Florian Fainelli <f.fainelli@gmail•com>
Subject: Re: [PATCH net-next 4/7] net: dsa: mv88e6xxx: add family to info
Date: Fri, 15 Apr 2016 21:11:49 +0200 [thread overview]
Message-ID: <20160415191149.GA18523@lunn.ch> (raw)
In-Reply-To: <1460744750-13896-5-git-send-email-vivien.didelot@savoirfairelinux.com>
On Fri, Apr 15, 2016 at 02:25:47PM -0400, Vivien Didelot wrote:
> Add an mv88e6xxx_family enum to the info structure for better family
> indentification.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
> ---
> drivers/net/dsa/mv88e6123.c | 6 ++--
> drivers/net/dsa/mv88e6131.c | 8 ++---
> drivers/net/dsa/mv88e6171.c | 8 ++---
> drivers/net/dsa/mv88e6352.c | 12 ++++----
> drivers/net/dsa/mv88e6xxx.c | 71 +++++----------------------------------------
> drivers/net/dsa/mv88e6xxx.h | 16 +++++++++-
> 6 files changed, 40 insertions(+), 81 deletions(-)
>
> diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c
> index 02bf16c..36a0340 100644
> --- a/drivers/net/dsa/mv88e6123.c
> +++ b/drivers/net/dsa/mv88e6123.c
> @@ -18,9 +18,9 @@
> #include "mv88e6xxx.h"
>
> static const struct mv88e6xxx_info mv88e6123_table[] = {
> - { MV88E6XXX_INFO(0x121, "Marvell 88E6123") },
> - { MV88E6XXX_INFO(0x161, "Marvell 88E6161") },
> - { MV88E6XXX_INFO(0x165, "Marvell 88E6165") },
> + { MV88E6XXX_INFO(6165, 0x121, "Marvell 88E6123") },
> + { MV88E6XXX_INFO(6165, 0x161, "Marvell 88E6161") },
> + { MV88E6XXX_INFO(6165, 0x165, "Marvell 88E6165") },
I think
> + { MV88E6XXX_INFO(MV88E6XXX_FAMILY_6165, 0x165, "Marvell 88E6165") },
is clearer. It is hard to know what these values mean unless you go
look at the macro.
Andrew
next prev parent reply other threads:[~2016-04-15 19:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 18:25 [PATCH net-next 0/7] net: dsa: mv88e6xxx: factorize switch info Vivien Didelot
2016-04-15 18:25 ` [PATCH net-next 1/7] net: dsa: mv88e6xxx: drop double ds assignment Vivien Didelot
2016-04-15 18:25 ` [PATCH net-next 2/7] net: dsa: mv88e6xxx: drop revision probing Vivien Didelot
2016-04-15 19:16 ` Andrew Lunn
2016-04-15 18:25 ` [PATCH net-next 3/7] net: dsa: mv88e6xxx: add switch info Vivien Didelot
2016-04-15 19:13 ` Andrew Lunn
2016-04-15 18:25 ` [PATCH net-next 4/7] net: dsa: mv88e6xxx: add family to info Vivien Didelot
2016-04-15 19:11 ` Andrew Lunn [this message]
[not found] ` <notmuch-sha1-5b8efc36765bacf253ff62234056042d5c4c5c37>
2016-04-15 21:06 ` Vivien Didelot
2016-04-15 18:25 ` [PATCH net-next 5/7] net: dsa: mv88e6xxx: add number of ports " Vivien Didelot
2016-04-15 18:25 ` [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database " Vivien Didelot
2016-04-15 19:35 ` Andrew Lunn
2016-04-15 20:24 ` Vivien Didelot
2016-04-15 20:27 ` Andrew Lunn
2016-04-15 18:25 ` [PATCH net-next 7/7] net: dsa: mv88e6xxx: drop switch id Vivien Didelot
2016-04-15 19:38 ` Andrew Lunn
2016-04-15 21:00 ` Vivien Didelot
2016-04-15 21:51 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415191149.GA18523@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kernel@savoirfairelinux$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox