From: Andrew Lunn <andrew@lunn•ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kernel@savoirfairelinux•com,
"David S. Miller" <davem@davemloft•net>,
Florian Fainelli <f.fainelli@gmail•com>
Subject: Re: [PATCH net-next 2/7] net: dsa: mv88e6xxx: drop revision probing
Date: Fri, 15 Apr 2016 21:16:24 +0200 [thread overview]
Message-ID: <20160415191624.GC18523@lunn.ch> (raw)
In-Reply-To: <1460744750-13896-3-git-send-email-vivien.didelot@savoirfairelinux.com>
> --- a/drivers/net/dsa/mv88e6xxx.c
> +++ b/drivers/net/dsa/mv88e6xxx.c
> @@ -2663,11 +2663,15 @@ int mv88e6xxx_setup_ports(struct dsa_switch *ds)
> int mv88e6xxx_setup_common(struct dsa_switch *ds)
> {
> struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
> + int id;
>
> ps->ds = ds;
> mutex_init(&ps->smi_mutex);
>
> - ps->id = REG_READ(REG_PORT(0), PORT_SWITCH_ID) & 0xfff0;
> + id = REG_READ(REG_PORT(0), PORT_SWITCH_ID);
> +
> + ps->id = id & 0xfff0;
> + ps->rev = id & 0xf;
ps->rev is not actually used anywhere. Drop it.
Andrew
next prev parent reply other threads:[~2016-04-15 19:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 18:25 [PATCH net-next 0/7] net: dsa: mv88e6xxx: factorize switch info Vivien Didelot
2016-04-15 18:25 ` [PATCH net-next 1/7] net: dsa: mv88e6xxx: drop double ds assignment Vivien Didelot
2016-04-15 18:25 ` [PATCH net-next 2/7] net: dsa: mv88e6xxx: drop revision probing Vivien Didelot
2016-04-15 19:16 ` Andrew Lunn [this message]
2016-04-15 18:25 ` [PATCH net-next 3/7] net: dsa: mv88e6xxx: add switch info Vivien Didelot
2016-04-15 19:13 ` Andrew Lunn
2016-04-15 18:25 ` [PATCH net-next 4/7] net: dsa: mv88e6xxx: add family to info Vivien Didelot
2016-04-15 19:11 ` Andrew Lunn
[not found] ` <notmuch-sha1-5b8efc36765bacf253ff62234056042d5c4c5c37>
2016-04-15 21:06 ` Vivien Didelot
2016-04-15 18:25 ` [PATCH net-next 5/7] net: dsa: mv88e6xxx: add number of ports " Vivien Didelot
2016-04-15 18:25 ` [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database " Vivien Didelot
2016-04-15 19:35 ` Andrew Lunn
2016-04-15 20:24 ` Vivien Didelot
2016-04-15 20:27 ` Andrew Lunn
2016-04-15 18:25 ` [PATCH net-next 7/7] net: dsa: mv88e6xxx: drop switch id Vivien Didelot
2016-04-15 19:38 ` Andrew Lunn
2016-04-15 21:00 ` Vivien Didelot
2016-04-15 21:51 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415191624.GC18523@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kernel@savoirfairelinux$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox