From: Johan Hedberg <johan.hedberg@gmail•com>
To: Andy Lutomirski <luto@kernel•org>
Cc: x86@kernel•org, linux-kernel@vger•kernel.org,
linux-arch@vger•kernel.org, Borislav Petkov <bp@alien8•de>,
Nadav Amit <nadav.amit@gmail•com>,
Kees Cook <keescook@chromium•org>,
Brian Gerst <brgerst@gmail•com>,
"kernel-hardening@lists•openwall.com"
<kernel-hardening@lists•openwall.com>,
Linus Torvalds <torvalds@linux-foundation•org>,
Josh Poimboeuf <jpoimboe@redhat•com>, Jann Horn <jann@thejh•net>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Marcel Holtmann <marcel@holtmann•org>,
Gustavo Padovan <gustavo@padovan•org>,
"David S. Miller" <davem@davemloft•net>,
linux-bluetooth@vger•kernel.org,
Herbert Xu <herbert@gondor•apana.org.au>,
netdev@vger•kernel.org
Subject: Re: [PATCH v4 01/16] bluetooth: Switch SMP to crypto_cipher_encrypt_one()
Date: Fri, 24 Jun 2016 10:19:08 +0300 [thread overview]
Message-ID: <20160624071908.GA7040@t440s> (raw)
In-Reply-To: <9a1ddd10d96898f8a2c94c3f3d37073c73ba50c9.1466741835.git.luto@kernel.org>
On Thu, Jun 23, 2016, Andy Lutomirski wrote:
> SMP does ECB crypto on stack buffers. This is complicated and
> fragile, and it will not work if the stack is virtually allocated.
>
> Switch to the crypto_cipher interface, which is simpler and safer.
>
> Cc: Marcel Holtmann <marcel@holtmann•org>
> Cc: Gustavo Padovan <gustavo@padovan•org>
> Cc: Johan Hedberg <johan.hedberg@gmail•com>
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: linux-bluetooth@vger•kernel.org
> Cc: Herbert Xu <herbert@gondor•apana.org.au>
> Cc: netdev@vger•kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel•org>
> ---
> net/bluetooth/smp.c | 67 ++++++++++++++++++++++-------------------------------
> 1 file changed, 28 insertions(+), 39 deletions(-)
Acked-and-tested-by: Johan Hedberg <johan.hedberg@intel•com>
Johan
prev parent reply other threads:[~2016-06-24 7:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1466741835.git.luto@kernel.org>
2016-06-24 4:22 ` [PATCH v4 01/16] bluetooth: Switch SMP to crypto_cipher_encrypt_one() Andy Lutomirski
2016-06-24 6:10 ` Herbert Xu
2016-06-24 7:19 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624071908.GA7040@t440s \
--to=johan.hedberg@gmail$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=brgerst@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gustavo@padovan$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jann@thejh$(echo .)net \
--cc=jpoimboe@redhat$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kernel-hardening@lists$(echo .)openwall.com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-bluetooth@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luto@kernel$(echo .)org \
--cc=marcel@holtmann$(echo .)org \
--cc=nadav.amit@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox