From: Jiri Pirko <jiri@resnulli•us>
To: Roopa Prabhu <roopa@cumulusnetworks•com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, nogahf@mellanox•com, idosch@mellanox•com,
eladr@mellanox•com, yotamg@mellanox•com, ogerlitz@mellanox•com,
nikolay@cumulusnetworks•com, linville@tuxdriver•com,
tgraf@suug•ch, gospo@cumulusnetworks•com, sfeldma@gmail•com,
sd@queasysnail•net, eranbe@mellanox•com, ast@plumgrid•com,
edumazet@google•com, hannes@stressinduktion•org,
f.fainelli@gmail•com, dsa@cumulusnetworks•com
Subject: Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg
Date: Tue, 23 Aug 2016 16:52:00 +0200 [thread overview]
Message-ID: <20160823145159.GC1975@nanopsycho> (raw)
In-Reply-To: <57BC61CD.9020005@cumulusnetworks.com>
Tue, Aug 23, 2016 at 04:46:37PM CEST, roopa@cumulusnetworks•com wrote:
>On 8/23/16, 12:26 AM, Jiri Pirko wrote:
>> Tue, Aug 23, 2016 at 09:04:15AM CEST, davem@davemloft•net wrote:
>>> From: Jiri Pirko <jiri@resnulli•us>
>>> Date: Tue, 23 Aug 2016 08:53:18 +0200
>>>
>>>> Anyway I think that next level of nesting is not necessary. On
>>>> contrary, it is wrong. The current level is extensible, mixed and
>>>> flagged already. I don't see any reason why not to add whatever kind of
>>>> stats here. What makes IFLA_STATS_LINK_SW_64 or for example
>>>> IFLA_STATS_LINK_HW_ACL so special it has to be nested in some other
>>>> attr? I would understand it it would be values of one family, but that
>>>> is not the case.
>>> First, I agree with Roopa. If we want to put this stuff out
>>> there is should be bucketed together in a nested attribute with
>>> other similar stats specifications.
>> Well I still don't think that IFLA_STATS_LINK_SW_64 and
>> IFLA_STATS_LINK_HW_ACL are related. You cannot put it under *DRIVER*
>> nest as IFLA_STATS_LINK_SW_64 are core stats.
>not sure i understand, why is this core stats ?.
>should a new logical device implement IFLA_STATS_LINK_64 or IFLA_STATS_LINK_SW_64 ?
>any other users ?.
>
>
>> So we can put them under
>> *MISC* nest attr. But that is exactly purpose of the top-level here.
>> /me confused
>
>By design top level is for higher level grouping of stats (that also helps us maintain a lean higher
>level filter space). They are mainly categories of stats. for example we have a nested link
>XSTATS attribute..which are again a break down of stats already counted in IFLA_STATS_LINK_64.
>That's why I think we can group this into another kind of breakdown stats.
I give up. What name do you suggest for the nested attribute?
Thanks.
next prev parent reply other threads:[~2016-08-23 15:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 13:17 [patch net-next v6_repost 0/3] return offloaded stats as default and expose original sw stats Jiri Pirko
2016-08-19 13:17 ` [patch net-next v6_repost 1/3] netdevice: add SW statistics ndo Jiri Pirko
2016-08-19 13:17 ` [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg Jiri Pirko
2016-08-23 5:51 ` Roopa Prabhu
2016-08-23 6:53 ` Jiri Pirko
2016-08-23 7:04 ` David Miller
2016-08-23 7:26 ` Jiri Pirko
2016-08-23 14:46 ` Roopa Prabhu
2016-08-23 14:52 ` Jiri Pirko [this message]
2016-08-24 2:46 ` Roopa Prabhu
2016-08-19 13:17 ` [patch net-next v6_repost 3/3] mlxsw: spectrum: Implement SW stats ndo and expose HW stats by default Jiri Pirko
2016-08-22 23:35 ` [patch net-next v6_repost 0/3] return offloaded stats as default and expose original sw stats David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823145159.GC1975@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=ast@plumgrid$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=eladr@mellanox$(echo .)com \
--cc=eranbe@mellanox$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=idosch@mellanox$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=nogahf@mellanox$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
--cc=sfeldma@gmail$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
--cc=yotamg@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox