From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net, nogahf@mellanox•com,
idosch@mellanox•com, eladr@mellanox•com, yotamg@mellanox•com,
ogerlitz@mellanox•com, nikolay@cumulusnetworks•com,
linville@tuxdriver•com, tgraf@suug•ch, gospo@cumulusnetworks•com,
sfeldma@gmail•com, sd@queasysnail•net, eranbe@mellanox•com,
ast@plumgrid•com, edumazet@google•com,
hannes@stressinduktion•org, f.fainelli@gmail•com,
dsa@cumulusnetworks•com
Subject: Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg
Date: Mon, 22 Aug 2016 22:51:57 -0700 [thread overview]
Message-ID: <57BBE47D.3060805@cumulusnetworks.com> (raw)
In-Reply-To: <1471612650-4508-3-git-send-email-jiri@resnulli.us>
On 8/19/16, 6:17 AM, Jiri Pirko wrote:
> From: Nogah Frankel <nogahf@mellanox•com>
>
> Add a nested attribute of SW stats to if_stats_msg
> under IFLA_STATS_LINK_SW_64.
>
> Signed-off-by: Nogah Frankel <nogahf@mellanox•com>
> Reviewed-by: Ido Schimmel <idosch@mellanox•com>
> Signed-off-by: Jiri Pirko <jiri@mellanox•com>
> ---
> include/uapi/linux/if_link.h | 1 +
> net/core/rtnetlink.c | 21 +++++++++++++++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index a1b5202..1c9b808 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -825,6 +825,7 @@ enum {
> IFLA_STATS_LINK_64,
> IFLA_STATS_LINK_XSTATS,
> IFLA_STATS_LINK_XSTATS_SLAVE,
> + IFLA_STATS_LINK_SW_64,
>
hate to sound like a broken record here...
sorry, but like I have been saying throughout this patch series,
i don't think I can ack a new attribute for so called 'software stats' at the
same level as existing IFLA_STATS_LINK_64. It just adds ambiguity for existing stats and
confusion for future stats.
Today's IFLA_STATS64 or IFLA_STATS_LINK_64 provides aggregate stats
and historically its been 'HW only' or 'SW only' or 'HW + SW'. It depends on the driver. logical devices
provide pure 'SW only' stats here. There is no real reason to qualify them now. The user/app
has only cared about and will continue to care about only aggregate stats. That requirement
has never changed.
Everything else is breakdown for debug-ability.., hence should be in this second bucket I
have been talking about (these are traditionally available via ethtool today).
I am not arguing against the value of the stats this patch series provides. But, since the beginning
of the stats api, I have always talked about a nested extensible attribute for drivers who wish to
break their stats down. so, I have only been requesting to put this so called 'software stats' attribute
in a new nested attribute which can be extended for other such specially qualified stats.
And, I thought we had agreed on such an attribute. I mention such a nested attribute
here again on your previous post: http://marc.info/?l=linux-netdev&m=147085641703885&w=2
Thanks,
Roopa
next prev parent reply other threads:[~2016-08-23 5:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 13:17 [patch net-next v6_repost 0/3] return offloaded stats as default and expose original sw stats Jiri Pirko
2016-08-19 13:17 ` [patch net-next v6_repost 1/3] netdevice: add SW statistics ndo Jiri Pirko
2016-08-19 13:17 ` [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg Jiri Pirko
2016-08-23 5:51 ` Roopa Prabhu [this message]
2016-08-23 6:53 ` Jiri Pirko
2016-08-23 7:04 ` David Miller
2016-08-23 7:26 ` Jiri Pirko
2016-08-23 14:46 ` Roopa Prabhu
2016-08-23 14:52 ` Jiri Pirko
2016-08-24 2:46 ` Roopa Prabhu
2016-08-19 13:17 ` [patch net-next v6_repost 3/3] mlxsw: spectrum: Implement SW stats ndo and expose HW stats by default Jiri Pirko
2016-08-22 23:35 ` [patch net-next v6_repost 0/3] return offloaded stats as default and expose original sw stats David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57BBE47D.3060805@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=ast@plumgrid$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=eladr@mellanox$(echo .)com \
--cc=eranbe@mellanox$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=idosch@mellanox$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=nogahf@mellanox$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
--cc=sfeldma@gmail$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
--cc=yotamg@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox