* [PATCH 1/1] mwifiex: remove superfluous condition
@ 2016-07-31 10:39 Heinrich Schuchardt
[not found] ` <1469961555-2123-1-git-send-email-xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2016-07-31 10:39 UTC (permalink / raw)
To: Amitkumar Karwar, Nishant Sarmukadam, Kalle Valo
Cc: linux-wireless, netdev, linux-kernel, Heinrich Schuchardt
for_each_property_of_node is only executed if the
property prop is not NULL.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx•de>
---
drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
index 7897037..128add8 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
@@ -1482,7 +1482,7 @@ int mwifiex_dnld_dt_cfgdata(struct mwifiex_private *priv,
continue;
/* property header is 6 bytes, data must fit in cmd buffer */
- if (prop && prop->value && prop->length > 6 &&
+ if (prop->value && prop->length > 6 &&
prop->length <= MWIFIEX_SIZE_OF_CMD_BUFFER - S_DS_GEN) {
ret = mwifiex_send_cmd(priv, HostCmd_CMD_CFG_DATA,
HostCmd_ACT_GEN_SET, 0,
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1469961555-2123-1-git-send-email-xypron.glpk-Mmb7MZpHnFY@public.gmane.org>]
* RE: [PATCH 1/1] mwifiex: remove superfluous condition [not found] ` <1469961555-2123-1-git-send-email-xypron.glpk-Mmb7MZpHnFY@public.gmane.org> @ 2016-08-01 10:46 ` Amitkumar Karwar 2016-09-03 10:00 ` [1/1] " Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Amitkumar Karwar @ 2016-08-01 10:46 UTC (permalink / raw) To: Heinrich Schuchardt, Nishant Sarmukadam, Kalle Valo Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org > From: Heinrich Schuchardt [mailto:xypron.glpk-Mmb7MZpHnFY@public•gmane.org] > Sent: Sunday, July 31, 2016 4:09 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org; linux- > kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org; Heinrich Schuchardt > Subject: [PATCH 1/1] mwifiex: remove superfluous condition > > for_each_property_of_node is only executed if the property prop is not > NULL. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public•gmane.org> > --- > drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > index 7897037..128add8 100644 > --- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > @@ -1482,7 +1482,7 @@ int mwifiex_dnld_dt_cfgdata(struct mwifiex_private > *priv, > continue; > > /* property header is 6 bytes, data must fit in cmd buffer > */ > - if (prop && prop->value && prop->length > 6 && > + if (prop->value && prop->length > 6 && > prop->length <= MWIFIEX_SIZE_OF_CMD_BUFFER - S_DS_GEN) { > ret = mwifiex_send_cmd(priv, HostCmd_CMD_CFG_DATA, > HostCmd_ACT_GEN_SET, 0, Thanks. The patch looks fine to me. Acked-by: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public•gmane.org> Regards, Amitkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [1/1] mwifiex: remove superfluous condition [not found] ` <1469961555-2123-1-git-send-email-xypron.glpk-Mmb7MZpHnFY@public.gmane.org> 2016-08-01 10:46 ` Amitkumar Karwar @ 2016-09-03 10:00 ` Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Kalle Valo @ 2016-09-03 10:00 UTC (permalink / raw) To: Heinrich Schuchardt Cc: Amitkumar Karwar, Nishant Sarmukadam, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Heinrich Schuchardt Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public•gmane.org> wrote: > for_each_property_of_node is only executed if the > property prop is not NULL. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public•gmane.org> > Acked-by: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public•gmane.org> Thanks, 1 patch applied to wireless-drivers-next.git: 2f69e67058fb mwifiex: remove superfluous condition -- Sent by pwcli https://patchwork.kernel.org/patch/9253329/ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-03 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-31 10:39 [PATCH 1/1] mwifiex: remove superfluous condition Heinrich Schuchardt
[not found] ` <1469961555-2123-1-git-send-email-xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
2016-08-01 10:46 ` Amitkumar Karwar
2016-09-03 10:00 ` [1/1] " Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox