From: Zach Brown <zach.brown@ni•com>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: <mlindner@marvell•com>, <stephen@networkplumber•org>,
<netdev@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<devel@driverdev•osuosl.org>,
<florian.c.schilhabel@googlemail•com>,
<Larry.Finger@lwfinger•net>, <gregkh@linuxfoundation•org>,
<rpurdie@rpsys•net>, <j.anaszewski@samsung•com>,
<linux-leds@vger•kernel.org>, Andrew Lunn <andrew@lunn•ch>
Subject: Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change
Date: Wed, 12 Oct 2016 10:57:58 -0500 [thread overview]
Message-ID: <20161012155757.GA29538@zach-desktop> (raw)
In-Reply-To: <1eb3afdb-0236-65e3-64be-09cc6eeda533@gmail.com>
On Mon, Oct 10, 2016 at 02:03:32AM -0700, Florian Fainelli wrote:
> > +
> > +#ifdef CONFIG_LED_TRIGGER_PHY
> > +
> > +#include <linux/leds.h>
> > +#include <linux/phy.h>
> > +
> > +#define PHY_LINK_LED_MAX_TRIGGERS 5
> > +#define PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE 7
> > +#define PHY_MII_BUS_ID_SIZE (20 - 3)
>
> This particular constant may be something worth moving to
> include/linux/phy.h eventually.
> --
> Florian
MII_BUS_ID_SIZE is defined in include/linux/phy.h but it's defined after
phy_led_triggers.h is included so phy_led_triggers.h doesn't have access.
I could move the definition of MII_BUS_ID_SIZE above the include, but that
seemed ugly. Do you have any suggestions?
prev parent reply other threads:[~2016-10-12 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 21:14 [PATCH 0/3] Add support for led triggers on phy link state change Zach Brown
2016-10-07 21:14 ` [RFC v3 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace Zach Brown
2016-10-07 21:14 ` [RFC v3 2/3] phy: Encapsulate actions performed during link state changes into function phy_adjust_link Zach Brown
2016-10-07 21:14 ` [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change Zach Brown
2016-10-10 9:03 ` Florian Fainelli
2016-10-11 20:56 ` Andrew Lunn
2016-10-12 15:57 ` Zach Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012155757.GA29538@zach-desktop \
--to=zach.brown@ni$(echo .)com \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=andrew@lunn$(echo .)ch \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=florian.c.schilhabel@googlemail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=j.anaszewski@samsung$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=mlindner@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rpurdie@rpsys$(echo .)net \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox