From: Andrew Lunn <andrew@lunn•ch>
To: Volodymyr Bendiuga <volodymyr.bendiuga@westermo•se>
Cc: vivien.didelot@savoirfairelinux•com, f.fainelli@gmail•com,
netdev@vger•kernel.org
Subject: Re: [PATCH] net:mv88e6xxx: dispose irq mapping
Date: Tue, 6 Dec 2016 16:08:56 +0100 [thread overview]
Message-ID: <20161206150856.GG26615@lunn.ch> (raw)
In-Reply-To: <7717215e-dddd-14af-196f-e638b5c60649@westermo.se>
On Tue, Dec 06, 2016 at 04:00:27PM +0100, Volodymyr Bendiuga wrote:
> Hi Andrew,
>
> thanks for you comments and time taken to review. I will make a new
>
> version which will indicate net-next tree.
>
> About mv88e6xxx_remove(), this function will not be called
Correct, which is why i said:
> and the error path of mv88e6xxx_probe().
which will be called on EPRODE_DEFFER.
> irq_dispose_mapping() is also called in mv88e6xxx_g2_irq_free(), so
> I put it in a similar
The mapping for chip->device_irq is made in mv88e6xxx_g2_irq_setup(),
so the disposal of the mapping logically goes in
mv88e6xxx_g2_irq_free().
Andrew
prev parent reply other threads:[~2016-12-06 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1481018743-27208-1-git-send-email-volodymyr.bendiuga@westermo.se>
2016-12-06 14:19 ` [PATCH] net:mv88e6xxx: dispose irq mapping Andrew Lunn
2016-12-06 15:00 ` Volodymyr Bendiuga
2016-12-06 15:08 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206150856.GG26615@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=volodymyr.bendiuga@westermo$(echo .)se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox