* [PATCH net-next] net: stmmac: allow changing the MTU while the interface is running
@ 2017-04-04 12:18 Niklas Cassel
2017-04-05 14:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2017-04-04 12:18 UTC (permalink / raw)
To: peppe.cavallaro, alexandre.torgue, Joao.Pinto, f.fainelli
Cc: netdev, linux-kernel, Niklas Cassel
From: Niklas Cassel <niklas.cassel@axis•com>
Setting ethtool ops for stmmac is only allowed when the interface is up.
Setting MTU (a netdev op) for stmmac is only allowed when the interface
is down.
It seems that the only reason why MTU cannot be changed when running is
that we have not bothered to implement a nice way to dealloc/alloc the
descriptor rings.
To make it less confusing for the user, call ndo_stop() and ndo_open()
from ndo_change_mtu(). This is not a nice way to dealloc/alloc the
descriptor rings, since it will announce that the interface is being
brought down/up to user space, but there are several other drivers doing
it this way, and it is arguably better than just returning -EBUSY.
Signed-off-by: Niklas Cassel <niklas.cassel@axis•com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index c1c63197ff73..fd268dc0df02 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3109,17 +3109,15 @@ static void stmmac_set_rx_mode(struct net_device *dev)
*/
static int stmmac_change_mtu(struct net_device *dev, int new_mtu)
{
- struct stmmac_priv *priv = netdev_priv(dev);
-
- if (netif_running(dev)) {
- netdev_err(priv->dev, "must be stopped to change its MTU\n");
- return -EBUSY;
- }
-
dev->mtu = new_mtu;
netdev_update_features(dev);
+ if (netif_running(dev)) {
+ stmmac_release(dev);
+ stmmac_open(dev);
+ }
+
return 0;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: stmmac: allow changing the MTU while the interface is running
2017-04-04 12:18 [PATCH net-next] net: stmmac: allow changing the MTU while the interface is running Niklas Cassel
@ 2017-04-05 14:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-04-05 14:49 UTC (permalink / raw)
To: niklas.cassel
Cc: peppe.cavallaro, alexandre.torgue, Joao.Pinto, f.fainelli, netdev,
linux-kernel, niklass
From: Niklas Cassel <niklas.cassel@axis•com>
Date: Tue, 4 Apr 2017 14:18:54 +0200
> From: Niklas Cassel <niklas.cassel@axis•com>
>
> Setting ethtool ops for stmmac is only allowed when the interface is up.
> Setting MTU (a netdev op) for stmmac is only allowed when the interface
> is down.
>
> It seems that the only reason why MTU cannot be changed when running is
> that we have not bothered to implement a nice way to dealloc/alloc the
> descriptor rings.
>
> To make it less confusing for the user, call ndo_stop() and ndo_open()
> from ndo_change_mtu(). This is not a nice way to dealloc/alloc the
> descriptor rings, since it will announce that the interface is being
> brought down/up to user space, but there are several other drivers doing
> it this way, and it is arguably better than just returning -EBUSY.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@axis•com>
You can't do this with no error handling.
Instead, you must do this using a "prepare", "commit" sequence.
First making sure you can reallocate all necessary resources,
and make the config change, before actually doing so.
You're not even checking if the re-open fails, meaning that an MTU
change can cause the interface to shut down. That is simply not
acceptable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-05 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-04 12:18 [PATCH net-next] net: stmmac: allow changing the MTU while the interface is running Niklas Cassel
2017-04-05 14:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox