From: Steffen Klassert <steffen.klassert@secunet•com>
To: David Miller <davem@davemloft•net>
Cc: <colin.king@canonical•com>, <netdev@vger•kernel.org>
Subject: Re: [PATCH][net-next] esp6: fix incorrect null pointer check on xo
Date: Wed, 19 Apr 2017 07:20:49 +0200 [thread overview]
Message-ID: <20170419052048.GC15917@secunet.com> (raw)
In-Reply-To: <20170418.131253.2065320027211688167.davem@davemloft.net>
On Tue, Apr 18, 2017 at 01:12:53PM -0400, David Miller wrote:
> From: Colin King <colin.king@canonical•com>
> Date: Tue, 18 Apr 2017 15:06:53 +0100
>
> Trimming the CC: list down to something that actually makes
> sense.
>
> > From: Colin Ian King <colin.king@canonical•com>
> >
> > The check for xo being null is incorrect, currently it is checking
> > for non-null, it should be checking for null.
> >
> > Detected with CoverityScan, CID#1429349 ("Dereference after null check")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical•com>
I've added
Fixes: 7862b4058b9f ("esp: Add gso handlers for esp4 and esp6")
and applied it to ipsec-next, thanks!
>
> At a minimum you should work to check that you are CC:'ing the person
> who added the code you are fixing. You can use "git blame" for this.
>
> Also, Steffen, you need to add the new IPSEC offload files to the
> MAINTAINERS entry for iPSEC.
Yes, will do a patch.
next prev parent reply other threads:[~2017-04-19 5:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 14:06 [PATCH][net-next] esp6: fix incorrect null pointer check on xo Colin King
2017-04-18 17:12 ` David Miller
2017-04-19 5:20 ` Steffen Klassert [this message]
2017-04-18 20:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419052048.GC15917@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=colin.king@canonical$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox