From: Stephen Hemminger <stephen@networkplumber•org>
To: Arnd Bergmann <arnd@arndb•de>
Cc: Stephen Hemminger <sthemmin@microsoft•com>,
netdev@vger•kernel.org, Haiyang Zhang <haiyangz@microsoft•com>,
linux-kernel@vger•kernel.org, devel@linuxdriverproject•org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly
Date: Wed, 21 Jun 2017 16:19:05 -0700 [thread overview]
Message-ID: <20170621161905.340c2be2@xeon-e3> (raw)
In-Reply-To: <20170621221714.278724-1-arnd@arndb.de>
On Thu, 22 Jun 2017 00:16:37 +0200
Arnd Bergmann <arnd@arndb•de> wrote:
> This structure member is hidden behind CONFIG_SYSFS, and we
> get a build error when that is disabled:
>
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
> drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_rxfh':
> drivers/net/hyperv/netvsc_drv.c:1181:25: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
>
> As the value is only set once to the argument of alloc_netdev_mq(),
> we can compare against that constant directly.
>
> Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
> Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of channels")
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
Yes this makes sense. The checks when changing values with ethtool are to avoid
to large a value > 64.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft•com>
next prev parent reply other threads:[~2017-06-21 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 22:16 [PATCH] netvsc: don't access netdev->num_rx_queues directly Arnd Bergmann
2017-06-21 22:21 ` Haiyang Zhang
2017-06-21 23:19 ` Stephen Hemminger [this message]
2017-06-22 17:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621161905.340c2be2@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=devel@linuxdriverproject$(echo .)org \
--cc=haiyangz@microsoft$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sthemmin@microsoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox