From: Jesper Dangaard Brouer <brouer@redhat•com>
To: John Fastabend <john.fastabend@gmail•com>
Cc: netdev@vger•kernel.org, brouer@redhat•com
Subject: Re: [PATCH 2/2] xdp: adjust xdp redirect tracepoint to include return error code
Date: Fri, 18 Aug 2017 14:29:46 +0200 [thread overview]
Message-ID: <20170818142946.1bad7203@redhat.com> (raw)
In-Reply-To: <5995F1D6.8040103@gmail.com>
On Thu, 17 Aug 2017 12:43:18 -0700
John Fastabend <john.fastabend@gmail•com> wrote:
> >>> @@ -2532,12 +2535,14 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp,
> >>> ri->map = NULL;
> >>> if (unlikely(!fwd)) {
> >>> bpf_warn_invalid_xdp_redirect(index);
>
> I think we should drop the warn_invalid now that we have a tracepoint.
> The tracepoint is much nicer for debugging vs a warning for what might
> be a valid case depending on xdp program.
I agree. I'll do that in a follow up patch. I'll likely remove the
bpf_warn_invalid_xdp_redirect() function completely.
We also have bpf_warn_invalid_xdp_action() but that might be relevant
to keep around(?).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2017-08-18 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 16:22 [PATCH 0/2] xdp: adjust xdp redirect tracepoint Jesper Dangaard Brouer
2017-08-17 16:22 ` [PATCH 1/2] ixgbe: change ndo_xdp_xmit return code on xmit errors Jesper Dangaard Brouer
2017-08-17 18:32 ` John Fastabend
2017-08-17 16:22 ` [PATCH 2/2] xdp: adjust xdp redirect tracepoint to include return error code Jesper Dangaard Brouer
2017-08-17 18:46 ` John Fastabend
2017-08-17 19:28 ` Jesper Dangaard Brouer
2017-08-17 19:43 ` John Fastabend
2017-08-18 12:29 ` Jesper Dangaard Brouer [this message]
2017-08-18 12:38 ` Daniel Borkmann
2017-08-18 23:19 ` [PATCH 0/2] xdp: adjust xdp redirect tracepoint David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818142946.1bad7203@redhat.com \
--to=brouer@redhat$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox