* [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size
@ 2017-09-22 14:03 Colin King
2017-09-22 16:51 ` Arend van Spriel
2017-09-25 8:23 ` brcmsmac: " Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2017-09-22 14:03 UTC (permalink / raw)
To: Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, Kalle Valo, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical•com>
Don't populate const array ucode_ofdm_rates on the stack, instead make it
static. Makes the object code smaller by 100 bytes:
Before:
text data bss dec hex filename
39482 564 0 40046 9c6e phy_cmn.o
After
text data bss dec hex filename
39326 620 0 39946 9c0a phy_cmn.o
(gcc 6.3.0, x86-64)
Signed-off-by: Colin Ian King <colin.king@canonical•com>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
index 1c4e9dd57960..3a13d176b221 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
@@ -1916,7 +1916,7 @@ void wlc_phy_txpower_update_shm(struct brcms_phy *pi)
pi->hwpwr_txcur);
for (j = TXP_FIRST_OFDM; j <= TXP_LAST_OFDM; j++) {
- const u8 ucode_ofdm_rates[] = {
+ static const u8 ucode_ofdm_rates[] = {
0x0c, 0x12, 0x18, 0x24, 0x30, 0x48, 0x60, 0x6c
};
offset = wlapi_bmac_rate_shm_offset(
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size
2017-09-22 14:03 [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size Colin King
@ 2017-09-22 16:51 ` Arend van Spriel
2017-09-25 4:20 ` Kalle Valo
2017-09-25 8:23 ` brcmsmac: " Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Arend van Spriel @ 2017-09-22 16:51 UTC (permalink / raw)
To: Colin King, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, Kalle Valo, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev
Cc: kernel-janitors, linux-kernel
Please use 'brcmsmac:' as prefix instead of 'brcm80211:'.
On 22-09-17 16:03, Colin King wrote:
> From: Colin Ian King <colin.king@canonical•com>
>
> Don't populate const array ucode_ofdm_rates on the stack, instead make it
> static. Makes the object code smaller by 100 bytes:
>
> Before:
> text data bss dec hex filename
> 39482 564 0 40046 9c6e phy_cmn.o
>
> After
> text data bss dec hex filename
> 39326 620 0 39946 9c0a phy_cmn.o
>
> (gcc 6.3.0, x86-64)
Acked-by: Arend van Spriel <arend.vanspriel@broadcom•com>
> Signed-off-by: Colin Ian King <colin.king@canonical•com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
> index 1c4e9dd57960..3a13d176b221 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
> @@ -1916,7 +1916,7 @@ void wlc_phy_txpower_update_shm(struct brcms_phy *pi)
> pi->hwpwr_txcur);
>
> for (j = TXP_FIRST_OFDM; j <= TXP_LAST_OFDM; j++) {
> - const u8 ucode_ofdm_rates[] = {
> + static const u8 ucode_ofdm_rates[] = {
> 0x0c, 0x12, 0x18, 0x24, 0x30, 0x48, 0x60, 0x6c
> };
> offset = wlapi_bmac_rate_shm_offset(
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size
2017-09-22 16:51 ` Arend van Spriel
@ 2017-09-25 4:20 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2017-09-25 4:20 UTC (permalink / raw)
To: Arend van Spriel
Cc: Colin King, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev, kernel-janitors, linux-kernel
Arend van Spriel <arend.vanspriel@broadcom•com> writes:
> Please use 'brcmsmac:' as prefix instead of 'brcm80211:'.
I can fix that.
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: brcmsmac: make const array ucode_ofdm_rates static, reduces object code size
2017-09-22 14:03 [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size Colin King
2017-09-22 16:51 ` Arend van Spriel
@ 2017-09-25 8:23 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2017-09-25 8:23 UTC (permalink / raw)
To: Colin Ian King
Cc: Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev, kernel-janitors, linux-kernel
Colin Ian King <colin.king@canonical•com> wrote:
> From: Colin Ian King <colin.king@canonical•com>
>
> Don't populate const array ucode_ofdm_rates on the stack, instead make it
> static. Makes the object code smaller by 100 bytes:
>
> Before:
> text data bss dec hex filename
> 39482 564 0 40046 9c6e phy_cmn.o
>
> After
> text data bss dec hex filename
> 39326 620 0 39946 9c0a phy_cmn.o
>
> (gcc 6.3.0, x86-64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical•com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom•com>
Patch applied to wireless-drivers-next.git, thanks.
d5633bb2c62a brcmsmac: make const array ucode_ofdm_rates static, reduces object code size
--
https://patchwork.kernel.org/patch/9966221/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-25 8:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 14:03 [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size Colin King
2017-09-22 16:51 ` Arend van Spriel
2017-09-25 4:20 ` Kalle Valo
2017-09-25 8:23 ` brcmsmac: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox