From: Jakub Kicinski <jakub.kicinski@netronome•com>
To: Manoj Gupta <manojgupta@chromium•org>
Cc: Matthias Kaehlcke <mka@chromium•org>,
Joe Perches <joe@perches•com>,
"David S . Miller" <davem@davemloft•net>,
Simon Horman <simon.horman@netronome•com>,
Dirk van der Merwe <dirk.vandermerwe@netronome•com>,
oss-drivers@netronome•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
Renato Golin <renato.golin@linaro•org>,
Guenter Roeck <groeck@chromium•org>,
Doug Anderson <dianders@chromium•org>
Subject: Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro
Date: Wed, 4 Oct 2017 17:56:03 -0700 [thread overview]
Message-ID: <20171004175603.4ba68737@cakuba.netronome.com> (raw)
In-Reply-To: <CAAMbb06DaOY1cnSXkuL0ZMSGzpwhfi_3d87mt8FMv+iYKDG03w@mail.gmail.com>
On Wed, 4 Oct 2017 17:38:22 -0700, Manoj Gupta wrote:
> On Wed, Oct 4, 2017 at 4:25 PM, Jakub Kicinski wrote:
> > On Wed, 4 Oct 2017 16:16:49 -0700, Matthias Kaehlcke wrote:
> >> > > Thanks for the suggestion. This seems a viable alternative if David
> >> > > and the NFP owners can live without the extra checking provided by
> >> > > __BF_FIELD_CHECK.
> >> >
> >> > The reason the __BF_FIELD_CHECK refuses to compile non-constant masks
> >> > is that it will require runtime ffs on the mask, which is potentially
> >> > costly. I would also feel quite stupid adding those macros to the nfp
> >> > driver, given that I specifically created the bitfield.h header to not
> >> > have to reimplement these in every driver I write/maintain.
> >>
> >> That make sense, thanks for providing more context.
> >>
> >> > Can you please test the patch I provided in the other reply?
> >>
> >> With this patch there are no errors when building the kernel with
> >> clang.
> >
> > Cool, thanks for checking! I will run it through full tests and queue
> > for upstreaming :)
>
> Just to let you know, using __BF_FIELD_CHECK macro will not Link with
> -O0 (GCC or Clang) since references to __compiletime_assert_xxx will
> not be cleaned up.
Do you mean the current nfp_eth_set_bit_config() will not work with -O0
on either complier, or any use of __BF_FIELD_CHECK() will not compile
with -O0?
next prev parent reply other threads:[~2017-10-05 0:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 20:05 [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro Matthias Kaehlcke
2017-10-03 21:50 ` Jakub Kicinski
2017-10-04 17:42 ` Matthias Kaehlcke
2017-10-04 17:44 ` David Miller
[not found] ` <CAAMbb05G=HBQweiWqYva_9zTnQqAcwMhJ0yYBUi26T04YA4CxQ@mail.gmail.com>
2017-10-04 18:17 ` Jakub Kicinski
2017-10-04 18:44 ` Matthias Kaehlcke
2017-10-24 16:56 ` Matthias Kaehlcke
2017-10-24 17:03 ` Jakub Kicinski
2017-10-24 17:13 ` Matthias Kaehlcke
2017-10-04 18:07 ` Joe Perches
2017-10-04 18:49 ` Matthias Kaehlcke
2017-10-04 22:22 ` Jakub Kicinski
2017-10-04 23:16 ` Matthias Kaehlcke
2017-10-04 23:25 ` Jakub Kicinski
2017-10-05 0:38 ` Manoj Gupta
2017-10-05 0:56 ` Jakub Kicinski [this message]
2017-10-05 1:50 ` Manoj Gupta
2017-10-05 2:06 ` Jakub Kicinski
2017-10-05 2:13 ` Manoj Gupta
2017-10-09 17:29 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004175603.4ba68737@cakuba.netronome.com \
--to=jakub.kicinski@netronome$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dianders@chromium$(echo .)org \
--cc=dirk.vandermerwe@netronome$(echo .)com \
--cc=groeck@chromium$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=manojgupta@chromium$(echo .)org \
--cc=mka@chromium$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@netronome$(echo .)com \
--cc=renato.golin@linaro$(echo .)org \
--cc=simon.horman@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox