From: Jakub Kicinski <jakub.kicinski@netronome•com>
To: Matthias Kaehlcke <mka@chromium•org>
Cc: Manoj Gupta <manojgupta@chromium•org>,
"David S . Miller" <davem@davemloft•net>,
Simon Horman <simon.horman@netronome•com>,
Dirk van der Merwe <dirk.vandermerwe@netronome•com>,
oss-drivers@netronome•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
Renato Golin <renato.golin@linaro•org>,
Guenter Roeck <groeck@chromium•org>,
Doug Anderson <dianders@chromium•org>
Subject: Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro
Date: Tue, 24 Oct 2017 10:03:56 -0700 [thread overview]
Message-ID: <20171024100356.63bcbb2f@cakuba.netronome.com> (raw)
In-Reply-To: <20171024165603.GA96615@google.com>
On Tue, 24 Oct 2017 09:56:03 -0700, Matthias Kaehlcke wrote:
> > @@ -561,6 +568,6 @@ int __nfp_eth_set_speed(struct nfp_nsp *nsp, unsigned int speed)
> > */
> > int __nfp_eth_set_split(struct nfp_nsp *nsp, unsigned int lanes)
> > {
> > - return nfp_eth_set_bit_config(nsp, NSP_ETH_RAW_PORT, NSP_ETH_PORT_LANES,
> > + return NFP_ETH_SET_BIT_CONFIG(nsp, NSP_ETH_RAW_PORT, NSP_ETH_PORT_LANES,
> > lanes, NSP_ETH_CTRL_SET_LANES);
> > }
>
> Do you plan to send this as an official patch?
Sorry... Dirk is prepping a larger series for this area of code and it
got stuck there a bit :S He says it's coming any day now...
next prev parent reply other threads:[~2017-10-24 17:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 20:05 [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro Matthias Kaehlcke
2017-10-03 21:50 ` Jakub Kicinski
2017-10-04 17:42 ` Matthias Kaehlcke
2017-10-04 17:44 ` David Miller
[not found] ` <CAAMbb05G=HBQweiWqYva_9zTnQqAcwMhJ0yYBUi26T04YA4CxQ@mail.gmail.com>
2017-10-04 18:17 ` Jakub Kicinski
2017-10-04 18:44 ` Matthias Kaehlcke
2017-10-24 16:56 ` Matthias Kaehlcke
2017-10-24 17:03 ` Jakub Kicinski [this message]
2017-10-24 17:13 ` Matthias Kaehlcke
2017-10-04 18:07 ` Joe Perches
2017-10-04 18:49 ` Matthias Kaehlcke
2017-10-04 22:22 ` Jakub Kicinski
2017-10-04 23:16 ` Matthias Kaehlcke
2017-10-04 23:25 ` Jakub Kicinski
2017-10-05 0:38 ` Manoj Gupta
2017-10-05 0:56 ` Jakub Kicinski
2017-10-05 1:50 ` Manoj Gupta
2017-10-05 2:06 ` Jakub Kicinski
2017-10-05 2:13 ` Manoj Gupta
2017-10-09 17:29 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024100356.63bcbb2f@cakuba.netronome.com \
--to=jakub.kicinski@netronome$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dianders@chromium$(echo .)org \
--cc=dirk.vandermerwe@netronome$(echo .)com \
--cc=groeck@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=manojgupta@chromium$(echo .)org \
--cc=mka@chromium$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@netronome$(echo .)com \
--cc=renato.golin@linaro$(echo .)org \
--cc=simon.horman@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox