From: Jiri Pirko <jiri@resnulli•us>
To: David Ahern <dsahern@gmail•com>
Cc: Nogah Frankel <nogahf@mellanox•com>,
David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"jhs@mojatatu•com" <jhs@mojatatu•com>,
"xiyou.wangcong@gmail•com" <xiyou.wangcong@gmail•com>,
mlxsw <mlxsw@mellanox•com>, "andrew@lunn•ch" <andrew@lunn•ch>,
"vivien.didelot@savoirfairelinux•com"
<vivien.didelot@savoirfairelinux•com>,
"f.fainelli@gmail•com" <f.fainelli@gmail•com>,
"michael.chan@broadcom•com" <michael.chan@broadcom•com>,
"ganeshgr@chelsio•com" <ganeshgr@chelsio•com>,
Saeed Mahameed <saeedm@mellanox•com>,
Matan Barak <matanb@mellanox•com>,
Leon Romanovsky <leonro@mellanox•com>,
Ido Schimmel <idosch@mellanox•com>,
"jakub.kicinski@netronome•com" <jakub.kicinski@netronome•com>,
"simon.horman@netronome•com" <simon.horman@netr
Subject: Re: [patch net-next RFC 1/9] net_sch: red: Add offload ability to RED qdisc
Date: Tue, 31 Oct 2017 08:41:51 +0100 [thread overview]
Message-ID: <20171031074151.GD1972@nanopsycho.orion> (raw)
In-Reply-To: <c02f7bb1-b534-64fb-8beb-d5f379773fab@gmail.com>
Mon, Oct 30, 2017 at 08:24:20PM CET, dsahern@gmail•com wrote:
>On 10/30/17 7:54 AM, Nogah Frankel wrote:
>>>> diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
>>>> index 0e88cc2..743c42a 100644
>>>> --- a/include/uapi/linux/pkt_sched.h
>>>> +++ b/include/uapi/linux/pkt_sched.h
>>>> @@ -255,6 +255,7 @@ struct tc_red_qopt {
>>>> #define TC_RED_ECN 1
>>>> #define TC_RED_HARDDROP 2
>>>> #define TC_RED_ADAPTATIVE 4
>>>> +#define TC_RED_OFFLOADED 8
>>>> };
>>>>
>>>> struct tc_red_xstats {
>>>
>>> What keeps a user from setting this flag in the tc_red_qopt it
>>> passes into the a change operation?
>>
>> Nothing keeps the user from doing it, but it has no effect.
>> The decision to offload is the driver's only.
>> It is basically a read-only flag.
>>
>
>If it is read-only, then attempts to set it from userspace should cause
>the command to fail.
That breaks uapi. Consider existing userspace app sending garbage in
that bit and new kernel which randomly fails upon the garbage.
next prev parent reply other threads:[~2017-10-31 7:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 8:56 [patch net-next RFC 0/9] qdisc RED offload Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 1/9] net_sch: red: Add offload ability to RED qdisc Jiri Pirko
2017-10-30 12:20 ` David Miller
2017-10-30 13:54 ` Nogah Frankel
2017-10-30 19:24 ` David Ahern
2017-10-31 7:41 ` Jiri Pirko [this message]
2017-10-31 14:59 ` David Ahern
2017-10-31 15:03 ` Jiri Pirko
2017-10-30 12:47 ` Roman Mashak
2017-10-30 14:10 ` Nogah Frankel
2017-10-30 8:56 ` [patch net-next RFC 2/9] net_sch: mqprio: Change TC_SETUP_MQPRIO to TC_SETUP_QDISC_MQPRIO Jiri Pirko
2017-11-01 15:31 ` Simon Horman
2017-11-02 6:48 ` Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 3/9] net_sch: cbs: Change TC_SETUP_CBS to TC_SETUP_QDISC_CBS Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 4/9] mlxsw: reg: Add cwtp & cwtpm registers Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 5/9] mlxsw: spectrum: Support RED qdisc offload Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 6/9] mlxsw: reg: Add ext and tc-cong counter groups Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 7/9] mlxsw: spectrum: Collect tclass related stats periodically Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 8/9] mlxsw: spectrum: Support RED xstats Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 9/9] mlxsw: spectrum: Support general qdisc stats Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031074151.GD1972@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=ganeshgr@chelsio$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=leonro@mellanox$(echo .)com \
--cc=matanb@mellanox$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nogahf@mellanox$(echo .)com \
--cc=saeedm@mellanox$(echo .)com \
--cc=simon.horman@netr \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox