From: Roman Mashak <mrv@mojatatu•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net, nogahf@mellanox•com,
jhs@mojatatu•com, xiyou.wangcong@gmail•com, mlxsw@mellanox•com,
andrew@lunn•ch, vivien.didelot@savoirfairelinux•com,
f.fainelli@gmail•com, michael.chan@broadcom•com,
ganeshgr@chelsio•com, saeedm@mellanox•com, matanb@mellanox•com,
leonro@mellanox•com, idosch@mellanox•com,
jakub.kicinski@netronome•com, simon.horman@netronome•com,
pieter.jansenvanvuuren@netronome•com, john.hurley@netronome•com,
alexander.h.duyck@intel•com, ogerlitz@mellanox•com,
john.fastabend@gmail•com
Subject: Re: [patch net-next RFC 1/9] net_sch: red: Add offload ability to RED qdisc
Date: Mon, 30 Oct 2017 08:47:04 -0400 [thread overview]
Message-ID: <85wp3col9z.fsf@mojatatu.com> (raw)
In-Reply-To: <20171030085613.8697-2-jiri@resnulli.us> (Jiri Pirko's message of "Mon, 30 Oct 2017 09:56:05 +0100")
Jiri Pirko <jiri@resnulli•us> writes:
[...]
> +static void red_unoffload(struct Qdisc *sch)
> +{
> + struct net_device *dev = qdisc_dev(sch);
> + struct tc_red_qopt_offload opt = {
> + .handle = sch->handle,
> + .command = TC_RED_DESTROY,
> + .parent = sch->parent,
> + };
> +
> + if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc)
> + return;
> +
> + dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_QDISC_RED, &opt);
> +}
> +
> @@ -162,6 +179,28 @@ static const struct nla_policy red_policy[TCA_RED_MAX + 1] = {
> [TCA_RED_MAX_P] = { .type = NLA_U32 },
> };
>
> +static int red_offload(struct Qdisc *sch)
> +{
> + struct red_sched_data *q = qdisc_priv(sch);
> + struct net_device *dev = qdisc_dev(sch);
> + struct tc_red_qopt_offload opt = {
> + .handle = sch->handle,
> + .command = TC_RED_REPLACE,
> + .parent = sch->parent,
> + .set = {
> + .min = q->parms.qth_min >> q->parms.Wlog,
> + .max = q->parms.qth_max >> q->parms.Wlog,
> + .probability = q->parms.max_P,
> + .is_ecn = red_use_ecn(q),
> + },
> + };
> +
> + if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc)
> + return -EOPNOTSUPP;
> +
> + return dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_QDISC_RED, &opt);
> +}
> +
[...]
Can't red_unoffload() and red_offload() be unified in a single API? For
example, red_offload(struct Qdisc *sch, bool enable) ?
next prev parent reply other threads:[~2017-10-30 12:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 8:56 [patch net-next RFC 0/9] qdisc RED offload Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 1/9] net_sch: red: Add offload ability to RED qdisc Jiri Pirko
2017-10-30 12:20 ` David Miller
2017-10-30 13:54 ` Nogah Frankel
2017-10-30 19:24 ` David Ahern
2017-10-31 7:41 ` Jiri Pirko
2017-10-31 14:59 ` David Ahern
2017-10-31 15:03 ` Jiri Pirko
2017-10-30 12:47 ` Roman Mashak [this message]
2017-10-30 14:10 ` Nogah Frankel
2017-10-30 8:56 ` [patch net-next RFC 2/9] net_sch: mqprio: Change TC_SETUP_MQPRIO to TC_SETUP_QDISC_MQPRIO Jiri Pirko
2017-11-01 15:31 ` Simon Horman
2017-11-02 6:48 ` Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 3/9] net_sch: cbs: Change TC_SETUP_CBS to TC_SETUP_QDISC_CBS Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 4/9] mlxsw: reg: Add cwtp & cwtpm registers Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 5/9] mlxsw: spectrum: Support RED qdisc offload Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 6/9] mlxsw: reg: Add ext and tc-cong counter groups Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 7/9] mlxsw: spectrum: Collect tclass related stats periodically Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 8/9] mlxsw: spectrum: Support RED xstats Jiri Pirko
2017-10-30 8:56 ` [patch net-next RFC 9/9] mlxsw: spectrum: Support general qdisc stats Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85wp3col9z.fsf@mojatatu.com \
--to=mrv@mojatatu$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=ganeshgr@chelsio$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john.hurley@netronome$(echo .)com \
--cc=leonro@mellanox$(echo .)com \
--cc=matanb@mellanox$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nogahf@mellanox$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=pieter.jansenvanvuuren@netronome$(echo .)com \
--cc=saeedm@mellanox$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox