From: Andrew Lunn <andrew@lunn•ch>
To: Bhaskar Upadhaya <bhaskar.upadhaya@nxp•com>
Cc: Russell King - ARM Linux <linux@armlinux•org.uk>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode
Date: Fri, 1 Dec 2017 20:12:50 +0100 [thread overview]
Message-ID: <20171201191250.GG22599@lunn.ch> (raw)
In-Reply-To: <AM3PR04MB449A2C7FDF78431360961E48C390@AM3PR04MB449.eurprd04.prod.outlook.com>
> So do we need to introduce a new interface type
> PHY_INTERFACE_MODE_2500SGMII or is there a way to deal with 2.5G
> SGMII ?
And just adding to what Florian said, you don't just add a new define
like this, you also need to add a user of it. Posting your MAC and PHY
driver making use of this symbol will make it a lot clearer why it is
needed and how it should be used.
Andrew
next prev parent reply other threads:[~2017-12-01 19:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 4:30 [PATCH 1/1] phy: Add 2.5G SGMII interface mode Bhaskar Upadhaya
2017-11-30 15:50 ` Andrew Lunn
2017-11-30 17:16 ` Bhaskar Upadhaya
2017-11-30 17:34 ` David Miller
2017-11-30 17:41 ` Andrew Lunn
2017-11-30 18:15 ` Russell King - ARM Linux
2017-11-30 18:26 ` Andrew Lunn
2017-11-30 18:53 ` Russell King - ARM Linux
2017-12-01 18:40 ` Bhaskar Upadhaya
2017-12-01 18:44 ` Florian Fainelli
2017-12-01 19:12 ` Andrew Lunn [this message]
2017-11-30 17:33 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201191250.GG22599@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=bhaskar.upadhaya@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox