From: Jiri Pirko <jiri@resnulli•us>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, arkadis@mellanox•com, mlxsw@mellanox•com,
andrew@lunn•ch, vivien.didelot@savoirfairelinux•com,
f.fainelli@gmail•com, michael.chan@broadcom•com,
ganeshgr@chelsio•com, saeedm@mellanox•com, matanb@mellanox•com,
leonro@mellanox•com, idosch@mellanox•com,
jakub.kicinski@netronome•com, ast@kernel•org,
daniel@iogearbox•net, simon.horman@netronome•com,
pieter.jansenvanvuuren@netronome•com, john.hurley@netronome•com,
alexander.h.duyck@intel•com, linville@tuxdriver•com,
gospo@broadcom•com, steven.lin1@broadcom•com,
yuvalm@mellanox•com, ogerlitz@mellanox•com,
dsa@cumulusnetworks•com, roopa@cumulusnetworks•com
Subject: Re: [patch net-next 02/10] devlink: Add support for resource abstraction
Date: Wed, 20 Dec 2017 21:01:09 +0100 [thread overview]
Message-ID: <20171220200109.GC1760@nanopsycho> (raw)
In-Reply-To: <20171220.144358.1892414104907740492.davem@davemloft.net>
Wed, Dec 20, 2017 at 08:43:58PM CET, davem@davemloft•net wrote:
>From: Jiri Pirko <jiri@resnulli•us>
>Date: Wed, 20 Dec 2017 12:58:13 +0100
>
>> From: Arkadi Sharshevsky <arkadis@mellanox•com>
>>
>> Add support for hardware resource abstraction over devlink. Each resource
>> is identified via id, furthermore it contains information regarding its
>> size and its related sub resources. Each resource can also provide its
>> current occupancy.
>>
>> In some cases the sizes of some resources can be changed, yet for those
>> changes to take place a hot driver reload may be needed. The reload
>> capability will be introduced in the next patch.
>>
>> Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox•com>
>> Signed-off-by: Jiri Pirko <jiri@mellanox•com>
>
>In what units are these sizes? If it depends upon the resource, it would
>be great to have a way to introspect the units given a resource.
In this case the unit is "item". But you have a point. We'll figure this
out.
>
>> + struct devlink_resource_ops *resource_ops;
>
>Const?
>
>> +static inline int
>> +devlink_resource_register(struct devlink *devlink,
>> + const char *resource_name,
>> + bool top_hierarchy,
>> + u64 resource_size,
>> + u64 resource_id,
>> + u64 parent_resource_id,
>> + struct devlink_resource_ops *resource_ops)
>
>Const for resource_ops?
>
>> +int devlink_resource_register(struct devlink *devlink,
>> + const char *resource_name,
>> + bool top_hierarchy,
>> + u64 resource_size,
>> + u64 resource_id,
>> + u64 parent_resource_id,
>> + struct devlink_resource_ops *resource_ops)
>
>Likewise.
Ok, thanks!
next prev parent reply other threads:[~2017-12-20 20:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 11:58 [patch net-next 00/10] Add support for resource abstraction Jiri Pirko
2017-12-20 11:58 ` [patch net-next 01/10] devlink: Add per devlink instance lock Jiri Pirko
2017-12-20 11:58 ` [patch net-next 02/10] devlink: Add support for resource abstraction Jiri Pirko
2017-12-20 19:43 ` David Miller
2017-12-20 20:01 ` Jiri Pirko [this message]
2017-12-25 11:12 ` Arkadi Sharshevsky
2017-12-20 11:58 ` [patch net-next 03/10] devlink: Add support for reload Jiri Pirko
2017-12-20 11:58 ` [patch net-next 04/10] devlink: Add relation between dpipe and resource Jiri Pirko
2017-12-20 11:58 ` [patch net-next 05/10] mlxsw: pci: Add support for performing bus reset Jiri Pirko
2017-12-20 11:58 ` [patch net-next 06/10] mlxsw: spectrum: Register KVD resources with devlink Jiri Pirko
2017-12-20 11:58 ` [patch net-next 07/10] mlxsw: spectrum_dpipe: Connect dpipe tables to resources Jiri Pirko
2017-12-20 11:58 ` [patch net-next 08/10] mlxsw: spectrum: Add support for getting kvdl occupancy Jiri Pirko
2017-12-20 11:58 ` [patch net-next 09/10] mlxsw: pci: Add support for getting resource through devlink Jiri Pirko
2017-12-20 11:58 ` [patch net-next 10/10] mlxsw: core: Add support for reload Jiri Pirko
2017-12-20 19:23 ` [patch net-next 00/10] Add support for resource abstraction David Ahern
2017-12-20 20:03 ` Jiri Pirko
2017-12-20 21:51 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220200109.GC1760@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arkadis@mellanox$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=ganeshgr@chelsio$(echo .)com \
--cc=gospo@broadcom$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=john.hurley@netronome$(echo .)com \
--cc=leonro@mellanox$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=matanb@mellanox$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=pieter.jansenvanvuuren@netronome$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=saeedm@mellanox$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
--cc=steven.lin1@broadcom$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=yuvalm@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox