From: Jiri Pirko <jiri@resnulli•us>
To: David Ahern <dsahern@gmail•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, jhs@mojatatu•com,
xiyou.wangcong@gmail•com, mlxsw@mellanox•com, andrew@lunn•ch,
vivien.didelot@savoirfairelinux•com, f.fainelli@gmail•com,
michael.chan@broadcom•com, ganeshgr@chelsio•com,
saeedm@mellanox•com, matanb@mellanox•com, leonro@mellanox•com,
idosch@mellanox•com, jakub.kicinski@netronome•com,
simon.horman@netronome•com, pieter.jansenvanvuuren@netronome•com,
john.hurley@netronome•com, alexander.h.duyck@intel•com,
ogerlitz@mellanox•com, john.fastabend@gmail•com,
daniel@iogearbox•net
Subject: Re: [patch iproute2 net-next v11 2/4] tc: introduce tc_qdisc_block_exists helper
Date: Sat, 20 Jan 2018 10:33:42 +0100 [thread overview]
Message-ID: <20180120093342.GD2147@nanopsycho.orion> (raw)
In-Reply-To: <e4ee3e40-faf8-0c4c-aa15-392858e4d576@gmail.com>
Fri, Jan 19, 2018 at 09:45:57PM CET, dsahern@gmail•com wrote:
>On 1/17/18 2:48 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox•com>
>>
>> This hepler used qdisc dump to list all qdisc and find if block index in
>> question is used by any of them. That means the block with specified
>> index exists.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox•com>
>> ---
>> tc/tc_qdisc.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> tc/tc_util.h | 2 ++
>> 2 files changed, 63 insertions(+)
>>
>> diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c
>> index 70279b9..3f91558 100644
>> --- a/tc/tc_qdisc.c
>> +++ b/tc/tc_qdisc.c
>> @@ -412,3 +412,64 @@ int do_qdisc(int argc, char **argv)
>> fprintf(stderr, "Command \"%s\" is unknown, try \"tc qdisc help\".\n", *argv);
>> return -1;
>> }
>> +
>> +struct tc_qdisc_block_exists_ctx {
>> + __u32 block_index;
>> + bool found;
>> +};
>> +
>> +static int tc_qdisc_block_exists_cb(const struct sockaddr_nl *who,
>> + struct nlmsghdr *n, void *arg)
>> +{
>> + struct tc_qdisc_block_exists_ctx *ctx = arg;
>> + struct tcmsg *t = NLMSG_DATA(n);
>> + int len = n->nlmsg_len;
>> + struct rtattr *tb[TCA_MAX+1];
>
>reverse xmas tree
:) Will fix
>
>> +
>> + if (n->nlmsg_type != RTM_NEWQDISC)
>> + return 0;
>> +
>> + len -= NLMSG_LENGTH(sizeof(*t));
>> + if (len < 0)
>> + return -1;
>> +
>> + parse_rtattr(tb, TCA_MAX, TCA_RTA(t), len);
>> +
>> + if (tb[TCA_KIND] == NULL)
>> + return -1;
>> +
>> + if (tb[TCA_INGRESS_BLOCK] &&
>> + RTA_PAYLOAD(tb[TCA_INGRESS_BLOCK]) >= sizeof(__u32)) {
>
>why not just == sizeof(__u32) since that's what it should be?
test1:~/iproute2$ git grep "== sizeof(__u32)" | grep RTA_PAYLOAD| wc -l
1
test1:~/iproute2$ git grep ">= sizeof(__u32)" | grep RTA_PAYLOAD| wc -l
42
I just go with the flow :)
>
>> + __u32 block = rta_getattr_u32(tb[TCA_INGRESS_BLOCK]);
>> +
>> + if (block && block == ctx->block_index)
>
>block > 0 test should not be needed. If someone is calling
>tc_qdisc_block_exists, then block_index should be > 0 in which case you
>just need block == ctx->block_index
Right. Will Fix.
>
>
>> + ctx->found = true;
>> + }
>> +
>> + if (tb[TCA_EGRESS_BLOCK] &&
>> + RTA_PAYLOAD(tb[TCA_EGRESS_BLOCK]) >= sizeof(__u32)) {
>> + __u32 block = rta_getattr_u32(tb[TCA_EGRESS_BLOCK]);
>> +
>> + if (block && block == ctx->block_index)
>
>same 2 comments for this block
ack
>
>> + ctx->found = true;
>> + }
>> + return 0;
>> +}
>> +
>> +int tc_qdisc_block_exists(__u32 block_index)
>
>This should be bool since you are returning true / false
Ah, missed that. Fixing.
>
>> +{
>> + struct tc_qdisc_block_exists_ctx ctx = { .block_index = block_index };
>> + struct tcmsg t = { .tcm_family = AF_UNSPEC };
>> +
>> + if (rtnl_dump_request(&rth, RTM_GETQDISC, &t, sizeof(t)) < 0) {
>> + perror("Cannot send dump request");
>> + return false;
>> + }
>> +
>> + if (rtnl_dump_filter(&rth, tc_qdisc_block_exists_cb, &ctx) < 0) {
>> + perror("Dump terminated\n");
>> + return false;
>> + }
>> +
>> + return ctx.found;
>> +}
>> diff --git a/tc/tc_util.h b/tc/tc_util.h
>> index 1218610..72f4282 100644
>> --- a/tc/tc_util.h
>> +++ b/tc/tc_util.h
>> @@ -132,4 +132,6 @@ int prio_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt);
>> int cls_names_init(char *path);
>> void cls_names_uninit(void);
>>
>> +int tc_qdisc_block_exists(__u32 block_index);
>> +
>> #endif
>>
>
next prev parent reply other threads:[~2018-01-20 9:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 10:46 [patch net-next v11 00/13] net: sched: allow qdiscs to share filter block instances Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 01/13] net: sched: introduce support for multiple filter chain pointers registration Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 02/13] net: sched: introduce shared filter blocks infrastructure Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 03/13] net: sched: avoid usage of tp->q in tcf_classify Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 04/13] net: sched: introduce block mechanism to handle netif_keep_dst calls Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 05/13] net: sched: remove classid and q fields from tcf_proto Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 06/13] net: sched: keep track of offloaded filters and check tc offload feature Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 07/13] net: sched: use block index as a handle instead of qdisc when block is shared Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 08/13] net: sched: introduce ingress/egress block index attributes for qdisc Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 10/13] mlxsw: spectrum_acl: Reshuffle code around mlxsw_sp_acl_ruleset_create/destroy Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 11/13] mlxsw: spectrum_acl: Don't store netdev and ingress for ruleset unbind Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 12/13] mlxsw: spectrum_acl: Implement TC block sharing Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 13/13] mlxsw: spectrum_acl: Pass mlxsw_sp_port down to ruleset bind/unbind ops Jiri Pirko
2018-01-17 10:48 ` [patch iproute2 net-next v11 1/4] include: update rtnetlink header according to kernel Jiri Pirko
2018-01-17 10:48 ` [patch iproute2 net-next v11 2/4] tc: introduce tc_qdisc_block_exists helper Jiri Pirko
2018-01-19 20:45 ` David Ahern
2018-01-20 9:33 ` Jiri Pirko [this message]
2018-01-17 10:48 ` [patch iproute2 net-next v11 3/4] tc: introduce support for block-handle for filter operations Jiri Pirko
2018-01-19 20:51 ` David Ahern
2018-01-20 9:37 ` Jiri Pirko
2018-01-17 10:48 ` [patch iproute2 net-next v11 4/4] tc: implement ingress/egress block index attributes for qdiscs Jiri Pirko
2018-01-19 20:53 ` David Ahern
2018-01-17 19:55 ` [patch net-next v11 00/13] net: sched: allow qdiscs to share filter block instances David Miller
2018-01-17 20:03 ` David Miller
2018-01-17 20:18 ` Jiri Pirko
2018-01-17 20:45 ` Jiri Pirko
2018-01-17 21:33 ` David Miller
2018-01-17 23:35 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180120093342.GD2147@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=ganeshgr@chelsio$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john.hurley@netronome$(echo .)com \
--cc=leonro@mellanox$(echo .)com \
--cc=matanb@mellanox$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=pieter.jansenvanvuuren@netronome$(echo .)com \
--cc=saeedm@mellanox$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox