From: Jiri Pirko <jiri@resnulli•us>
To: David Ahern <dsahern@gmail•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, jhs@mojatatu•com,
xiyou.wangcong@gmail•com, mlxsw@mellanox•com, andrew@lunn•ch,
vivien.didelot@savoirfairelinux•com, f.fainelli@gmail•com,
michael.chan@broadcom•com, ganeshgr@chelsio•com,
saeedm@mellanox•com, matanb@mellanox•com, leonro@mellanox•com,
idosch@mellanox•com, jakub.kicinski@netronome•com,
simon.horman@netronome•com, pieter.jansenvanvuuren@netronome•com,
john.hurley@netronome•com, alexander.h.duyck@intel•com,
ogerlitz@mellanox•com, john.fastabend@gmail•com,
daniel@iogearbox•net
Subject: Re: [patch iproute2 net-next v11 3/4] tc: introduce support for block-handle for filter operations
Date: Sat, 20 Jan 2018 10:37:16 +0100 [thread overview]
Message-ID: <20180120093716.GE2147@nanopsycho.orion> (raw)
In-Reply-To: <2862d2ff-7a9c-cdaf-c3a3-3208b2ea61b3@gmail.com>
Fri, Jan 19, 2018 at 09:51:22PM CET, dsahern@gmail•com wrote:
>On 1/17/18 2:48 AM, Jiri Pirko wrote:
>> @@ -89,7 +93,21 @@ static int tc_filter_modify(int cmd, unsigned int flags, int argc, char **argv,
>> NEXT_ARG();
>> if (d[0])
>> duparg("dev", *argv);
>> + if (block_index) {
>> + fprintf(stderr, "Error: \"dev\" cannot be used in the same time as \"block\"\n");
>
>'in the same time' does not sound right. something like: 'dev and block
>are mutually exlusive'
ack
>
>> + return -1;
>> + }
>> strncpy(d, *argv, sizeof(d)-1);
>> + } else if (matches(*argv, "block") == 0) {
>> + NEXT_ARG();
>> + if (block_index)
>> + duparg("block", *argv);
>> + if (d[0]) {
>> + fprintf(stderr, "Error: \"block\" cannot be used in the same time as \"dev\"\n");
>
>same here. Correct the ones below as well.
ack
>
>
>> + return -1;
>> + }
>> + if (get_u32(&block_index, *argv, 0) || !block_index)
>> + invarg("invalid block index value", *argv);
next prev parent reply other threads:[~2018-01-20 9:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 10:46 [patch net-next v11 00/13] net: sched: allow qdiscs to share filter block instances Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 01/13] net: sched: introduce support for multiple filter chain pointers registration Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 02/13] net: sched: introduce shared filter blocks infrastructure Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 03/13] net: sched: avoid usage of tp->q in tcf_classify Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 04/13] net: sched: introduce block mechanism to handle netif_keep_dst calls Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 05/13] net: sched: remove classid and q fields from tcf_proto Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 06/13] net: sched: keep track of offloaded filters and check tc offload feature Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 07/13] net: sched: use block index as a handle instead of qdisc when block is shared Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 08/13] net: sched: introduce ingress/egress block index attributes for qdisc Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 10/13] mlxsw: spectrum_acl: Reshuffle code around mlxsw_sp_acl_ruleset_create/destroy Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 11/13] mlxsw: spectrum_acl: Don't store netdev and ingress for ruleset unbind Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 12/13] mlxsw: spectrum_acl: Implement TC block sharing Jiri Pirko
2018-01-17 10:46 ` [patch net-next v11 13/13] mlxsw: spectrum_acl: Pass mlxsw_sp_port down to ruleset bind/unbind ops Jiri Pirko
2018-01-17 10:48 ` [patch iproute2 net-next v11 1/4] include: update rtnetlink header according to kernel Jiri Pirko
2018-01-17 10:48 ` [patch iproute2 net-next v11 2/4] tc: introduce tc_qdisc_block_exists helper Jiri Pirko
2018-01-19 20:45 ` David Ahern
2018-01-20 9:33 ` Jiri Pirko
2018-01-17 10:48 ` [patch iproute2 net-next v11 3/4] tc: introduce support for block-handle for filter operations Jiri Pirko
2018-01-19 20:51 ` David Ahern
2018-01-20 9:37 ` Jiri Pirko [this message]
2018-01-17 10:48 ` [patch iproute2 net-next v11 4/4] tc: implement ingress/egress block index attributes for qdiscs Jiri Pirko
2018-01-19 20:53 ` David Ahern
2018-01-17 19:55 ` [patch net-next v11 00/13] net: sched: allow qdiscs to share filter block instances David Miller
2018-01-17 20:03 ` David Miller
2018-01-17 20:18 ` Jiri Pirko
2018-01-17 20:45 ` Jiri Pirko
2018-01-17 21:33 ` David Miller
2018-01-17 23:35 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180120093716.GE2147@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=ganeshgr@chelsio$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john.hurley@netronome$(echo .)com \
--cc=leonro@mellanox$(echo .)com \
--cc=matanb@mellanox$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=pieter.jansenvanvuuren@netronome$(echo .)com \
--cc=saeedm@mellanox$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox