From: Vinicius Costa Gomes <vinicius.gomes@intel•com>
To: intel-wired-lan@lists•osuosl.org
Cc: Vinicius Costa Gomes <vinicius.gomes@intel•com>,
jeffrey.t.kirsher@intel•com, netdev@vger•kernel.org,
jesus.sanchez-palencia@intel•com
Subject: [next-queue PATCH v6 01/10] igb: Fix not adding filter elements to the list
Date: Thu, 29 Mar 2018 14:07:42 -0700 [thread overview]
Message-ID: <20180329210751.11531-2-vinicius.gomes@intel.com> (raw)
In-Reply-To: <20180329210751.11531-1-vinicius.gomes@intel.com>
Because the order of the parameters passes to 'hlist_add_behind()' was
inverted, the 'parent' node was added "behind" the 'input', as input
is not in the list, this causes the 'input' node to be lost.
Fixes: 0e71def25281 ("igb: add support of RX network flow classification")
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel•com>
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index e77ba0d5866d..5975d432836f 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -2865,7 +2865,7 @@ static int igb_update_ethtool_nfc_entry(struct igb_adapter *adapter,
/* add filter to the list */
if (parent)
- hlist_add_behind(&parent->nfc_node, &input->nfc_node);
+ hlist_add_behind(&input->nfc_node, &parent->nfc_node);
else
hlist_add_head(&input->nfc_node, &adapter->nfc_filter_list);
--
2.16.3
next prev parent reply other threads:[~2018-03-29 21:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 21:07 [next-queue PATCH v6 00/10] igb: offloading of receive filters Vinicius Costa Gomes
2018-03-29 21:07 ` Vinicius Costa Gomes [this message]
2018-03-29 21:07 ` [next-queue PATCH v6 02/10] igb: Fix queue selection on MAC filters on i210 Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 03/10] igb: Enable the hardware traffic class feature bit for igb models Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 04/10] igb: Add support for MAC address filters specifying source addresses Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 05/10] igb: Add support for enabling queue steering in filters Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 06/10] igb: Allow filters to be added for the local MAC address Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 07/10] igb: Enable nfc filters to specify MAC addresses Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 08/10] igb: Add MAC address support for ethtool nftuple filters Vinicius Costa Gomes
2018-04-05 1:47 ` [Intel-wired-lan] " Brown, Aaron F
2018-04-05 17:59 ` Vinicius Costa Gomes
2018-04-07 2:11 ` Brown, Aaron F
2018-04-09 17:33 ` Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 09/10] igb: Add the skeletons for tc-flower offloading Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 10/10] igb: Add support for adding offloaded clsflower filters Vinicius Costa Gomes
2018-04-07 2:19 ` [Intel-wired-lan] " Brown, Aaron F
2018-04-09 17:36 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329210751.11531-2-vinicius.gomes@intel.com \
--to=vinicius.gomes@intel$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesus.sanchez-palencia@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox