From: Vinicius Costa Gomes <vinicius.gomes@intel•com>
To: "Brown\, Aaron F" <aaron.f.brown@intel•com>,
"intel-wired-lan\@lists.osuosl.org"
<intel-wired-lan@lists•osuosl.org>
Cc: "netdev\@vger.kernel.org" <netdev@vger•kernel.org>,
"Sanchez-Palencia\, Jesus" <jesus.sanchez-palencia@intel•com>
Subject: RE: [Intel-wired-lan] [next-queue PATCH v6 08/10] igb: Add MAC address support for ethtool nftuple filters
Date: Mon, 09 Apr 2018 10:33:46 -0700 [thread overview]
Message-ID: <874lkkl1xh.fsf@intel.com> (raw)
In-Reply-To: <309B89C4C689E141A5FF6A0C5FB2118B8C825976@ORSMSX101.amr.corp.intel.com>
Hi,
"Brown, Aaron F" <aaron.f.brown@intel•com> writes:
[...]
>
>>
>> I added that note in the hope that someone else would have an stronger
>> opinion about what to do.
>
> I don't have a strong opinion beyond my preference for an ideal world
> where everything works :) If the part simply cannot filter on the src
> address as a whole without the protocol I would ideally prefer an
> attempt in ethtool to set the filter on src address as a whole to
> return an error WHILE still allowing the filter to be set on an
> ethertype when the proto keyword is issued. If ethtool does not allow
> that fine grain of control then I think the way it is now is good, I'd
> rather have the annoyance of being able to set a filter that does
> nothing then not be able to set the more specific filter at all.
We are agreed. The next version of this series implements just that:
specifying the src address alone is an error, but if the classifier has
a src address and any other filter, it works.
Cheers,
next prev parent reply other threads:[~2018-04-09 17:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 21:07 [next-queue PATCH v6 00/10] igb: offloading of receive filters Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 01/10] igb: Fix not adding filter elements to the list Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 02/10] igb: Fix queue selection on MAC filters on i210 Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 03/10] igb: Enable the hardware traffic class feature bit for igb models Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 04/10] igb: Add support for MAC address filters specifying source addresses Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 05/10] igb: Add support for enabling queue steering in filters Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 06/10] igb: Allow filters to be added for the local MAC address Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 07/10] igb: Enable nfc filters to specify MAC addresses Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 08/10] igb: Add MAC address support for ethtool nftuple filters Vinicius Costa Gomes
2018-04-05 1:47 ` [Intel-wired-lan] " Brown, Aaron F
2018-04-05 17:59 ` Vinicius Costa Gomes
2018-04-07 2:11 ` Brown, Aaron F
2018-04-09 17:33 ` Vinicius Costa Gomes [this message]
2018-03-29 21:07 ` [next-queue PATCH v6 09/10] igb: Add the skeletons for tc-flower offloading Vinicius Costa Gomes
2018-03-29 21:07 ` [next-queue PATCH v6 10/10] igb: Add support for adding offloaded clsflower filters Vinicius Costa Gomes
2018-04-07 2:19 ` [Intel-wired-lan] " Brown, Aaron F
2018-04-09 17:36 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lkkl1xh.fsf@intel.com \
--to=vinicius.gomes@intel$(echo .)com \
--cc=aaron.f.brown@intel$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesus.sanchez-palencia@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox