From: Corentin Labbe <clabbe.montjoie@gmail•com>
To: Jose Abreu <Jose.Abreu@synopsys•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Joao Pinto <Joao.Pinto@synopsys•com>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Alexandre Torgue <alexandre.torgue@st•com>
Subject: Re: [PATCH net-next] net: stmmac: Populate missing callbacks in HWIF initialization
Date: Fri, 18 May 2018 16:25:36 +0200 [thread overview]
Message-ID: <20180518142536.GB11284@Red> (raw)
In-Reply-To: <a08345ae8576d5ebddcd31ee73beea18484a671d.1526550924.git.joabreu@synopsys.com>
On Thu, May 17, 2018 at 10:57:28AM +0100, Jose Abreu wrote:
> Some HW specific setusp, like sun8i, do not populate all the necessary
> callbacks, which is what HWIF helpers were expecting.
>
> Fix this by always trying to get the generic helpers and populate them
> if they were not previously populated by HW specific setup.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys•com>
> Fixes: 5f0456b43140 ("net: stmmac: Implement logic to automatically
> select HW Interface")
> Reported-by: Corentin Labbe <clabbe.montjoie@gmail•com>
> Cc: Corentin Labbe <clabbe.montjoie@gmail•com>
> Cc: David S. Miller <davem@davemloft•net>
> Cc: Joao Pinto <jpinto@synopsys•com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st•com>
> Cc: Alexandre Torgue <alexandre.torgue@st•com>
> ---
> Hi Corentin,
>
> Please check if this patch makes sun8i work again.
>
> Thanks and Best Regards,
> Jose Miguel Abreu
> ---
Hello
Tested-by: Corentin Labbe <clabbe.montjoie@gmail•com>
Thanks for the quick fix.
Note that this patch conflict with your next v3 serie
Regards
prev parent reply other threads:[~2018-05-18 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 9:57 [PATCH net-next] net: stmmac: Populate missing callbacks in HWIF initialization Jose Abreu
2018-05-18 14:25 ` Corentin Labbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518142536.GB11284@Red \
--to=clabbe.montjoie@gmail$(echo .)com \
--cc=Joao.Pinto@synopsys$(echo .)com \
--cc=Jose.Abreu@synopsys$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox