From: Jesper Dangaard Brouer <brouer@redhat•com>
To: Saeed Mahameed <saeedm@dev•mellanox.co.il>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail•com>,
Daniel Borkmann <borkmann@iogearbox•net>,
neerav.parikh@intel•com, pjwaskiewicz@gmail•com,
ttoukan.linux@gmail•com, Tariq Toukan <tariqt@mellanox•com>,
alexander.h.duyck@intel•com, peter.waskiewicz.jr@intel•com,
Opher Reviv <opher@mellanox•com>,
Rony Efraim <ronye@mellanox•com>,
netdev@vger•kernel.org, Saeed Mahameed <saeedm@mellanox•com>,
brouer@redhat•com
Subject: Re: [RFC bpf-next 2/6] net: xdp: RX meta data infrastructure
Date: Wed, 27 Jun 2018 16:15:17 +0200 [thread overview]
Message-ID: <20180627161517.31f1f7af@redhat.com> (raw)
In-Reply-To: <20180627024615.17856-3-saeedm@mellanox.com>
On Tue, 26 Jun 2018 19:46:11 -0700
Saeed Mahameed <saeedm@dev•mellanox.co.il> wrote:
> diff --git a/include/net/xdp.h b/include/net/xdp.h
> index 2deea7166a34..afe302613ae1 100644
> --- a/include/net/xdp.h
> +++ b/include/net/xdp.h
> @@ -138,6 +138,12 @@ xdp_set_data_meta_invalid(struct xdp_buff *xdp)
> xdp->data_meta = xdp->data + 1;
> }
>
> +static __always_inline void
> +xdp_reset_data_meta(struct xdp_buff *xdp)
> +{
> + xdp->data_meta = xdp->data_hard_start;
> +}
This is WRONG ... it should be:
xdp->data_meta = xdp->data;
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-06-27 14:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 2:46 [RFC bpf-next 0/6] XDP RX device meta data acceleration (WIP) Saeed Mahameed
2018-06-27 2:46 ` [RFC bpf-next 1/6] net: xdp: Add support for meta data flags requests Saeed Mahameed
2018-06-27 2:46 ` [RFC bpf-next 2/6] net: xdp: RX meta data infrastructure Saeed Mahameed
2018-06-27 14:15 ` Jesper Dangaard Brouer [this message]
2018-06-27 17:55 ` Saeed Mahameed
2018-07-02 8:01 ` Daniel Borkmann
2018-07-03 23:52 ` Saeed Mahameed
2018-07-03 23:01 ` Alexei Starovoitov
2018-07-04 0:57 ` Saeed Mahameed
2018-07-04 7:51 ` Daniel Borkmann
2018-07-05 17:18 ` Jakub Kicinski
2018-07-06 16:30 ` Alexei Starovoitov
2018-07-06 20:44 ` Waskiewicz Jr, Peter
2018-07-06 23:38 ` Alexei Starovoitov
2018-07-06 23:49 ` Waskiewicz Jr, Peter
2018-07-07 0:40 ` Jakub Kicinski
2018-07-07 1:00 ` Alexei Starovoitov
2018-07-07 1:20 ` Jakub Kicinski
2018-07-07 2:38 ` Alexei Starovoitov
2018-07-07 0:45 ` Alexei Starovoitov
2018-07-06 21:33 ` Jakub Kicinski
2018-07-06 23:42 ` Alexei Starovoitov
2018-07-07 0:08 ` Jakub Kicinski
2018-07-07 0:53 ` Alexei Starovoitov
2018-07-07 1:37 ` David Miller
2018-07-07 1:44 ` Jakub Kicinski
2018-07-07 2:51 ` Alexei Starovoitov
2018-07-07 1:27 ` David Miller
2018-06-27 2:46 ` [RFC bpf-next 3/6] net/mlx5e: Store xdp flags and meta data info Saeed Mahameed
2018-06-27 2:46 ` [RFC bpf-next 4/6] net/mlx5e: Pass CQE to RX handlers Saeed Mahameed
2018-06-27 2:46 ` [RFC bpf-next 5/6] net/mlx5e: Add XDP RX meta data support Saeed Mahameed
2018-07-04 8:28 ` Daniel Borkmann
2018-06-27 2:46 ` [RFC bpf-next 6/6] samples/bpf: Add meta data hash example to xdp_redirect_cpu Saeed Mahameed
2018-06-27 10:59 ` Jesper Dangaard Brouer
2018-06-27 18:04 ` Saeed Mahameed
2018-06-27 16:42 ` [RFC bpf-next 0/6] XDP RX device meta data acceleration (WIP) Parikh, Neerav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627161517.31f1f7af@redhat.com \
--to=brouer@redhat$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=borkmann@iogearbox$(echo .)net \
--cc=neerav.parikh@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=opher@mellanox$(echo .)com \
--cc=peter.waskiewicz.jr@intel$(echo .)com \
--cc=pjwaskiewicz@gmail$(echo .)com \
--cc=ronye@mellanox$(echo .)com \
--cc=saeedm@dev$(echo .)mellanox.co.il \
--cc=saeedm@mellanox$(echo .)com \
--cc=tariqt@mellanox$(echo .)com \
--cc=ttoukan.linux@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox