From: Peter Oskolkov <posk@google•com>
To: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Cc: Eric Dumazet <edumazet@google•com>,
Florian Westphal <fw@strlen•de>, Peter Oskolkov <posk@google•com>
Subject: [PATCH net-next 0/3] ip: Use rb trees for IP frag queue.
Date: Thu, 2 Aug 2018 22:45:57 +0000 [thread overview]
Message-ID: <20180802224600.43070-1-posk@google.com> (raw)
This patchset
* changes IPv4 defrag behavior to match that of IPv6: overlapping
fragments now cause the whole IP datagram to be discarded (suggested
by David Miller): there are no legitimate use cases for overlapping
fragments;
* changes IPv4 defrag queue from a list to a rb tree (suggested
by Eric Dumazet): this change removes a potential attach vector.
Upcoming patches will contain similar changes for IPv6 frag queue,
as well as a comprehensive IP defrag self-test (temporarily delayed).
Peter Oskolkov (3):
ip: discard IPv4 datagrams with overlapping segments.
net: modify skb_rbtree_purge to return the truesize of all purged
skbs.
ip: use rb trees for IP frag queue.
include/linux/skbuff.h | 11 +-
include/net/inet_frag.h | 3 +-
include/uapi/linux/snmp.h | 1 +
net/core/skbuff.c | 6 +-
net/ipv4/inet_fragment.c | 16 +-
net/ipv4/ip_fragment.c | 239 +++++++++++-------------
net/ipv4/proc.c | 1 +
net/ipv6/netfilter/nf_conntrack_reasm.c | 1 +
net/ipv6/reassembly.c | 1 +
9 files changed, 139 insertions(+), 140 deletions(-)
--
2.18.0.597.ga71716f1ad-goog
next reply other threads:[~2018-08-03 0:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 22:45 Peter Oskolkov [this message]
2018-08-02 22:45 ` [PATCH net-next 1/3] ip: discard IPv4 datagrams with overlapping segments Peter Oskolkov
2018-08-02 22:54 ` Stephen Hemminger
2018-08-02 23:33 ` Eric Dumazet
2018-08-02 23:56 ` Stephen Hemminger
2018-08-02 22:45 ` [PATCH net-next 2/3] net: modify skb_rbtree_purge to return the truesize of all purged skbs Peter Oskolkov
2018-08-02 22:46 ` [PATCH net-next 3/3] ip: use rb trees for IP frag queue Peter Oskolkov
2018-08-06 0:17 ` [PATCH net-next 0/3] ip: Use " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802224600.43070-1-posk@google.com \
--to=posk@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox