From: Stephen Hemminger <stephen@networkplumber•org>
To: Leslie Monis <lesliemonis@gmail•com>
Cc: jhs@mojatatu•com, netdev@vger•kernel.org, tahiliani@nitk•edu.in,
dhavaljkhandla26@gmail•com, hrishihiraskar@gmail•com,
bmanish15597@gmail•com, sdp.sachin@gmail•com
Subject: Re: [PATCH net-next 7/8] net: sched: pie: add derandomization mechanism
Date: Wed, 31 Oct 2018 09:38:27 -0700 [thread overview]
Message-ID: <20181031093827.011d289c@xeon-e3> (raw)
In-Reply-To: <1541002772-28040-8-git-send-email-lesliemonis@gmail.com>
On Wed, 31 Oct 2018 21:49:31 +0530
Leslie Monis <lesliemonis@gmail•com> wrote:
> diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
> index b68b367..88e605c 100644
> --- a/net/sched/sch_pie.c
> +++ b/net/sched/sch_pie.c
> @@ -58,6 +58,7 @@ struct pie_vars {
> u32 avg_dq_rate; /* bytes per pschedtime tick,scaled */
> u32 qlen_old; /* in bytes */
> bool active; /* inactive/active */
> + u64 accu_prob; /* accumulated drop probability */
> };
>
Although putting it at the end seems like a natural place, it creates
holes in the c structure. My recommendation would be to put the new
field after dq_tsstamp.
next prev parent reply other threads:[~2018-11-01 1:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 16:19 [PATCH net-next 0/8] net: sched: pie: align PIE implementation with RFC 8033 Leslie Monis
2018-10-31 16:19 ` [PATCH net-next 1/8] net: sched: pie: change value of QUEUE_THRESHOLD Leslie Monis
2018-10-31 16:19 ` [PATCH net-next 2/8] net: sched: pie: change default value of pie_params->target Leslie Monis
2018-10-31 16:19 ` [PATCH net-next 3/8] net: sched: pie: change default value of pie_params->tupdate Leslie Monis
2018-10-31 16:19 ` [PATCH net-next 4/8] net: sched: pie: change initial value of pie_vars->burst_time Leslie Monis
2018-10-31 16:19 ` [PATCH net-next 5/8] net: sched: pie: add more conditions to auto-tune alpha and beta Leslie Monis
2018-10-31 16:40 ` Stephen Hemminger
2018-10-31 16:19 ` [PATCH net-next 6/8] net: sched: pie: add mechanism to set PIE active/inactive Leslie Monis
2018-10-31 16:41 ` Stephen Hemminger
2018-10-31 16:19 ` [PATCH net-next 7/8] net: sched: pie: add derandomization mechanism Leslie Monis
2018-10-31 16:38 ` Stephen Hemminger [this message]
2018-10-31 16:19 ` [PATCH net-next 8/8] net: sched: pie: update references Leslie Monis
2018-10-31 16:36 ` [PATCH net-next 0/8] net: sched: pie: align PIE implementation with RFC 8033 Stephen Hemminger
2018-10-31 17:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031093827.011d289c@xeon-e3 \
--to=stephen@networkplumber$(echo .)org \
--cc=bmanish15597@gmail$(echo .)com \
--cc=dhavaljkhandla26@gmail$(echo .)com \
--cc=hrishihiraskar@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=lesliemonis@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sdp.sachin@gmail$(echo .)com \
--cc=tahiliani@nitk$(echo .)edu.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox