From: Andrew Lunn <andrew@lunn•ch>
To: Camelia Alexandra Groza <camelia.groza@nxp•com>
Cc: "f.fainelli@gmail•com" <f.fainelli@gmail•com>,
"hkallweit1@gmail•com" <hkallweit1@gmail•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"oss@buserror•net" <oss@buserror•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net] net: phy: guard against accessing a NULL features bitmap
Date: Fri, 11 Jan 2019 15:19:32 +0100 [thread overview]
Message-ID: <20190111141932.GC20924@lunn.ch> (raw)
In-Reply-To: <VI1PR04MB47994BB92D3E766C6B4E37C9F2850@VI1PR04MB4799.eurprd04.prod.outlook.com>
> > Hi Camelia
> >
> > A NULL features is a driver bug. So i would prefer to solve this
> > differently.
> >
> > Please make phy_driver_register() do a WARN_ON(!new_driver->features)
> > and return -EINVAL.
>
> I wasn't aware that features are mandatory. I'll make the change.
It was not origionally, but really it should be now.
> Yes, there are five drivers that don't have features configured: BCM8706, BCM8727, CS4340, TN2020 and KSZ8873MLL.
> I'm planning to send patches on net-next for the Cortina and
> Teranetics ones at least, but fixing the generic crash was my
> priority.
O.K, will take the others.
Thanks
Andrew
next prev parent reply other threads:[~2019-01-11 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 11:56 [PATCH net] net: phy: guard against accessing a NULL features bitmap Camelia Groza
2019-01-11 11:56 ` Camelia Groza
2019-01-11 13:37 ` Andrew Lunn
2019-01-11 13:37 ` Andrew Lunn
2019-01-11 14:09 ` Camelia Alexandra Groza
2019-01-11 14:09 ` Camelia Alexandra Groza
2019-01-11 14:19 ` Andrew Lunn [this message]
2019-01-11 14:19 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111141932.GC20924@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=camelia.groza@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss@buserror$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox