From: Andrew Lunn <andrew@lunn•ch>
To: Heiner Kallweit <hkallweit1@gmail•com>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next v2 2/4] net: phy: warn if phy_start is called from invalid state
Date: Mon, 21 Jan 2019 19:29:28 +0100 [thread overview]
Message-ID: <20190121182928.GC16212@lunn.ch> (raw)
In-Reply-To: <85441436-49f3-82c0-d550-d4ffa423ae12@gmail.com>
> For all invalid states phy_start() basically was a no-op. All it did was
> triggering a state machine run, but for all "running" states the poll
> loop was active anyway. And if called from PHY_DOWN, the state machine
> does nothing. Therefore I see no scenario where jumping to out would
> break anything.
Hi Heiner
It is useful to put this sort of analysis in the commit message. You
then won't get people like me asking about it.
Andrew
next prev parent reply other threads:[~2019-01-21 18:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 8:59 [PATCH net-next v2 0/4] net: phy: improve starting PHY Heiner Kallweit
2019-01-20 9:01 ` [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only Heiner Kallweit
2019-01-21 16:35 ` Andrew Lunn
2019-01-21 18:36 ` Heiner Kallweit
2019-01-21 18:42 ` Andrew Lunn
2019-01-21 21:52 ` Heiner Kallweit
2019-01-21 23:55 ` Andrew Lunn
2019-01-22 14:46 ` Lendacky, Thomas
2019-01-22 19:09 ` Heiner Kallweit
2019-01-23 2:50 ` S-k, Shyam-sundar
2019-01-20 9:02 ` [PATCH net-next v2 2/4] net: phy: warn if phy_start is called from invalid state Heiner Kallweit
2019-01-21 16:40 ` Andrew Lunn
2019-01-21 18:25 ` Heiner Kallweit
2019-01-21 18:29 ` Andrew Lunn [this message]
2019-01-21 18:30 ` Heiner Kallweit
2019-01-20 9:03 ` [PATCH net-next v2 3/4] net: phy: start interrupts in phy_start Heiner Kallweit
2019-01-20 9:05 ` [PATCH net-next v2 4/4] net: phy: change phy_start_interrupts to phy_request_interrupt Heiner Kallweit
2019-01-22 22:50 ` [PATCH net-next v2 0/4] net: phy: improve starting PHY David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121182928.GC16212@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox