From: Alexei Starovoitov <ast@kernel•org>
To: <davem@davemloft•net>
Cc: <daniel@iogearbox•net>, <peterz@infradead•org>,
<edumazet@google•com>, <jannh@google•com>,
<netdev@vger•kernel.org>, <kernel-team@fb•com>
Subject: [PATCH v2 bpf 0/3] bpf: fixes for lockdep and deadlocks
Date: Wed, 30 Jan 2019 18:12:42 -0800 [thread overview]
Message-ID: <20190131021245.1905869-1-ast@kernel.org> (raw)
v1->v2:
- reworded 2nd patch. It's a real dead lock. Not a false positive
- dropped the lockdep fix for up_read_non_owner in bpf_get_stackid
In addition to preempt_disable patch for socket filters
https://patchwork.ozlabs.org/patch/1032437/
First patch fixes lockdep false positive in percpu_freelist
Second patch fixes potential deadlock in bpf_prog_register
Third patch fixes another potential deadlock in stackmap access
from tracing bpf prog and from syscall.
Alexei Starovoitov (2):
bpf: fix lockdep false positive in percpu_freelist
bpf: fix potential deadlock in bpf_prog_register
Martin KaFai Lau (1):
bpf: Fix syscall's stackmap lookup potential deadlock
kernel/bpf/hashtab.c | 4 ++--
kernel/bpf/percpu_freelist.c | 41 +++++++++++++++++++++++++-----------
kernel/bpf/percpu_freelist.h | 4 ++++
kernel/bpf/syscall.c | 12 +++++++++--
kernel/trace/bpf_trace.c | 14 ++----------
5 files changed, 47 insertions(+), 28 deletions(-)
--
2.20.0
next reply other threads:[~2019-01-31 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 2:12 Alexei Starovoitov [this message]
2019-01-31 2:12 ` [PATCH v2 bpf 1/3] bpf: fix lockdep false positive in percpu_freelist Alexei Starovoitov
2019-01-31 2:12 ` [PATCH v2 bpf 2/3] bpf: fix potential deadlock in bpf_prog_register Alexei Starovoitov
2019-01-31 2:12 ` [PATCH v2 bpf 3/3] bpf: Fix syscall's stackmap lookup potential deadlock Alexei Starovoitov
2019-01-31 22:25 ` [PATCH v2 bpf 0/3] bpf: fixes for lockdep and deadlocks Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131021245.1905869-1-ast@kernel.org \
--to=ast@kernel$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jannh@google$(echo .)com \
--cc=kernel-team@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox