[RFC net-next 02/13] rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET

public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Florian Fainelli <f.fainelli@gmail•com>
To: netdev@vger•kernel.org
Cc: Florian Fainelli <f.fainelli@gmail•com>,
	Michael Chan <michael.chan@broadcom•com>,
	"David S. Miller" <davem@davemloft•net>,
	Derek Chickles <dchickles@marvell•com>,
	Satanand Burla <sburla@marvell•com>,
	Felix Manlunas <fmanlunas@marvell•com>,
	Saeed Mahameed <saeedm@mellanox•com>,
	Leon Romanovsky <leon@kernel•org>, Jiri Pirko <jiri@mellanox•com>,
	Ido Schimmel <idosch@mellanox•com>,
	Alexandre Belloni <alexandre.belloni@bootlin•com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip•com>,
	Jakub Kicinski <jakub.kicinski@netronome•com>,
	Ioana Radulescu <ruxandra.radulescu@nxp•com>,
	Ioana Ciornei <ioana.ciornei@nxp•com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	Ivan Vecera <ivecera@redhat•com>, Andrew Lunn <andrew@lunn•ch>,
	Vivien Didelot <vivien.didelot@gmail•com>,
	Dirk van der Merwe <dirk.vandermerwe@netronome•com>,
	"Francois H. Theron" <francois.theron@netronome•com>,
	Simon Horman <simon.horman@netronome•com>,
	Quentin Monnet <quentin.monnet@netronome•com>,
	Daniel Borkmann <daniel@iogearbox•net>,
	Eric Dumazet <edumazet@google•com>,
	John Hurley <john.hurley@netronome•com>,
	Edwin Peer <edwin.peer@netronome•com>,
	linux-kernel@vger•kernel.org (open list),
	linux-rdma@vger•kernel.org (open list:MELLANOX MLX5 core VPI
	driver),
	oss-drivers@netronome•com (open list:NETRONOME ETHERNET DRIVERS),
	devel@driverdev•osuosl.org (open list:STAGING SUBSYSTEM)
Subject: [RFC net-next 02/13] rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET
Date: Fri,  1 Feb 2019 14:06:46 -0800	[thread overview]
Message-ID: <20190201220657.30170-3-f.fainelli@gmail.com> (raw)
In-Reply-To: <20190201220657.30170-1-f.fainelli@gmail.com>

Following patches will change the way we communicate getting or setting
a port's attribute and use a blocking notifier to perform those tasks.

Prepare rocker to support receiving notifier events targeting
SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing
rocker_port_attr_{set,get} calls.

Signed-off-by: Florian Fainelli <f.fainelli@gmail•com>
---
 drivers/net/ethernet/rocker/rocker_main.c | 24 +++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index 62a205eba9f7..f25f7b4345b8 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -2827,6 +2827,27 @@ rocker_switchdev_port_obj_event(unsigned long event, struct net_device *netdev,
 	return notifier_from_errno(err);
 }
 
+static int
+rocker_switchdev_port_attr_event(unsigned long event, struct net_device *netdev,
+				 struct switchdev_notifier_port_attr_info
+				 *port_attr_info)
+{
+	int err = -EOPNOTSUPP;
+
+	switch (event) {
+	case SWITCHDEV_PORT_ATTR_SET:
+		err = rocker_port_attr_set(netdev, port_attr_info->attr,
+					   port_attr_info->trans);
+		break;
+	case SWITCHDEV_PORT_ATTR_GET:
+		err = rocker_port_attr_get(netdev, port_attr_info->attr);
+		break;
+	}
+
+	port_attr_info->handled = true;
+	return notifier_from_errno(err);
+}
+
 static int rocker_switchdev_blocking_event(struct notifier_block *unused,
 					   unsigned long event, void *ptr)
 {
@@ -2839,6 +2860,9 @@ static int rocker_switchdev_blocking_event(struct notifier_block *unused,
 	case SWITCHDEV_PORT_OBJ_ADD:
 	case SWITCHDEV_PORT_OBJ_DEL:
 		return rocker_switchdev_port_obj_event(event, dev, ptr);
+	case SWITCHDEV_PORT_ATTR_SET:
+	case SWITCHDEV_PORT_ATTR_GET:
+		return rocker_switchdev_port_attr_event(event, dev, ptr);
 	}
 
 	return NOTIFY_DONE;
-- 
2.17.1

next prev parent reply	other threads:[~2019-02-01 22:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01 22:06 [RFC net-next 00/13] Get rid of switchdev_ops Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 01/13] switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET Florian Fainelli
2019-02-02 15:48   ` Jiri Pirko
2019-02-01 22:06 ` Florian Fainelli [this message]
2019-02-01 22:06 ` [RFC net-next 03/13] net: dsa: Handle SWITCHDEV_PORT_ATTR_GET/SET Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 04/13] mlxsw: spectrum_switchdev: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 05/13] net: mscc: ocelot: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 06/13] staging: fsl-dpaa2: ethsw: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 07/13] bnxt: Handle SWITCHDEV_PORT_ATTR_GET event Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 08/13] liquidio: " Florian Fainelli
2019-02-02  1:38   ` Felix Manlunas
2019-02-01 22:06 ` [RFC net-next 09/13] mlxsw: switchx2: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 10/13] net/mlx5e: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 11/13] nfp: " Florian Fainelli
2019-02-02  3:45   ` Jakub Kicinski
2019-02-02  4:22     ` Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 12/13] netdevsim: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 13/13] net: switchdev: Replace port attr get/set SDO with a notification Florian Fainelli
2019-02-02 15:52 ` [RFC net-next 00/13] Get rid of switchdev_ops Jiri Pirko

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:62a205eba9f dfblob:f25f7b4345b )
 OR (
bs:"[RFC net-next 02/13] rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190201220657.30170-3-f.fainelli@gmail.com \
    --to=f.fainelli@gmail$(echo .)com \
    --cc=UNGLinuxDriver@microchip$(echo .)com \
    --cc=alexandre.belloni@bootlin$(echo .)com \
    --cc=andrew@lunn$(echo .)ch \
    --cc=daniel@iogearbox$(echo .)net \
    --cc=davem@davemloft$(echo .)net \
    --cc=dchickles@marvell$(echo .)com \
    --cc=devel@driverdev$(echo .)osuosl.org \
    --cc=dirk.vandermerwe@netronome$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=edwin.peer@netronome$(echo .)com \
    --cc=fmanlunas@marvell$(echo .)com \
    --cc=francois.theron@netronome$(echo .)com \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=idosch@mellanox$(echo .)com \
    --cc=ioana.ciornei@nxp$(echo .)com \
    --cc=ivecera@redhat$(echo .)com \
    --cc=jakub.kicinski@netronome$(echo .)com \
    --cc=jiri@mellanox$(echo .)com \
    --cc=john.hurley@netronome$(echo .)com \
    --cc=leon@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-rdma@vger$(echo .)kernel.org \
    --cc=michael.chan@broadcom$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=oss-drivers@netronome$(echo .)com \
    --cc=quentin.monnet@netronome$(echo .)com \
    --cc=ruxandra.radulescu@nxp$(echo .)com \
    --cc=saeedm@mellanox$(echo .)com \
    --cc=sburla@marvell$(echo .)com \
    --cc=simon.horman@netronome$(echo .)com \
    --cc=vivien.didelot@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox