public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli•us>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: netdev@vger•kernel.org, Michael Chan <michael.chan@broadcom•com>,
	"David S. Miller" <davem@davemloft•net>,
	Derek Chickles <dchickles@marvell•com>,
	Satanand Burla <sburla@marvell•com>,
	Felix Manlunas <fmanlunas@marvell•com>,
	Saeed Mahameed <saeedm@mellanox•com>,
	Leon Romanovsky <leon@kernel•org>, Jiri Pirko <jiri@mellanox•com>,
	Ido Schimmel <idosch@mellanox•com>,
	Alexandre Belloni <alexandre.belloni@bootlin•com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip•com>,
	Jakub Kicinski <jakub.kicinski@netronome•com>,
	Ioana Radulescu <ruxandra.radulescu@nxp•com>,
	Ioana Ciornei <ioana.ciornei@nxp•com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	Ivan Vecera <ivecera@redhat•com>, Andrew Lunn <andrew@lunn•ch>,
	Vivien Didelot <vivien.didelot@gmail•com>,
	Dirk van der Merwe <dirk.vandermerwe@netronome•com>,
	"Francois H. Theron" <francois.theron@netronome•com>,
	Simon Horman <simon.horman@netronome•com>,
	Quentin Monnet <quentin.monnet@netronome•com>,
	Daniel Borkmann <daniel@iogearbox•net>,
	Eric Dumazet <edumazet@google•com>,
	John Hurley <john.hurley@netronome•com>,
	Edwin Peer <edwin.peer@netronome•com>,
	open list <linux-kernel@vger•kernel.org>,
	"open list:MELLANOX MLX5 core VPI driver" 
	<linux-rdma@vger•kernel.org>,
	"open list:NETRONOME ETHERNET DRIVERS"
	<oss-drivers@netronome•com>,
	"open list:STAGING SUBSYSTEM" <devel@driverdev•osuosl.org>
Subject: Re: [RFC net-next 01/13] switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET
Date: Sat, 2 Feb 2019 16:48:32 +0100	[thread overview]
Message-ID: <20190202154832.GC2778@nanopsycho> (raw)
In-Reply-To: <20190201220657.30170-2-f.fainelli@gmail.com>

Fri, Feb 01, 2019 at 11:06:45PM CET, f.fainelli@gmail•com wrote:
>In preparation for allowing switchdev enabled drivers to veto specific
>attribute settings from within the context of the caller, introduce a
>new switchdev notifier type for port attributes.
>
>Suggested-by: Ido Schimmel <idosch@mellanox•com>
>Signed-off-by: Florian Fainelli <f.fainelli@gmail•com>
>---
> include/net/switchdev.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/include/net/switchdev.h b/include/net/switchdev.h
>index 63843ae5dc81..e62fb2693e00 100644
>--- a/include/net/switchdev.h
>+++ b/include/net/switchdev.h
>@@ -145,6 +145,9 @@ enum switchdev_notifier_type {
> 	SWITCHDEV_VXLAN_FDB_ADD_TO_DEVICE,
> 	SWITCHDEV_VXLAN_FDB_DEL_TO_DEVICE,
> 	SWITCHDEV_VXLAN_FDB_OFFLOADED,
>+
>+	SWITCHDEV_PORT_ATTR_SET, /* Blocking. */
>+	SWITCHDEV_PORT_ATTR_GET, /* Blocking. */

Not an UAPI, so you can put this right next to PORT_OBJ_* if needed.


> };
> 
> struct switchdev_notifier_info {
>@@ -167,6 +170,13 @@ struct switchdev_notifier_port_obj_info {
> 	bool handled;
> };
> 
>+struct switchdev_notifier_port_attr_info {
>+	struct switchdev_notifier_info info; /* must be first */
>+	struct switchdev_attr *attr;
>+	struct switchdev_trans *trans;
>+	bool handled;
>+};
>+
> static inline struct net_device *
> switchdev_notifier_info_to_dev(const struct switchdev_notifier_info *info)
> {
>-- 
>2.17.1
>

  reply	other threads:[~2019-02-02 15:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01 22:06 [RFC net-next 00/13] Get rid of switchdev_ops Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 01/13] switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET Florian Fainelli
2019-02-02 15:48   ` Jiri Pirko [this message]
2019-02-01 22:06 ` [RFC net-next 02/13] rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 03/13] net: dsa: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 04/13] mlxsw: spectrum_switchdev: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 05/13] net: mscc: ocelot: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 06/13] staging: fsl-dpaa2: ethsw: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 07/13] bnxt: Handle SWITCHDEV_PORT_ATTR_GET event Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 08/13] liquidio: " Florian Fainelli
2019-02-02  1:38   ` Felix Manlunas
2019-02-01 22:06 ` [RFC net-next 09/13] mlxsw: switchx2: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 10/13] net/mlx5e: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 11/13] nfp: " Florian Fainelli
2019-02-02  3:45   ` Jakub Kicinski
2019-02-02  4:22     ` Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 12/13] netdevsim: " Florian Fainelli
2019-02-01 22:06 ` [RFC net-next 13/13] net: switchdev: Replace port attr get/set SDO with a notification Florian Fainelli
2019-02-02 15:52 ` [RFC net-next 00/13] Get rid of switchdev_ops Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190202154832.GC2778@nanopsycho \
    --to=jiri@resnulli$(echo .)us \
    --cc=UNGLinuxDriver@microchip$(echo .)com \
    --cc=alexandre.belloni@bootlin$(echo .)com \
    --cc=andrew@lunn$(echo .)ch \
    --cc=daniel@iogearbox$(echo .)net \
    --cc=davem@davemloft$(echo .)net \
    --cc=dchickles@marvell$(echo .)com \
    --cc=devel@driverdev$(echo .)osuosl.org \
    --cc=dirk.vandermerwe@netronome$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=edwin.peer@netronome$(echo .)com \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=fmanlunas@marvell$(echo .)com \
    --cc=francois.theron@netronome$(echo .)com \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=idosch@mellanox$(echo .)com \
    --cc=ioana.ciornei@nxp$(echo .)com \
    --cc=ivecera@redhat$(echo .)com \
    --cc=jakub.kicinski@netronome$(echo .)com \
    --cc=jiri@mellanox$(echo .)com \
    --cc=john.hurley@netronome$(echo .)com \
    --cc=leon@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-rdma@vger$(echo .)kernel.org \
    --cc=michael.chan@broadcom$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=oss-drivers@netronome$(echo .)com \
    --cc=quentin.monnet@netronome$(echo .)com \
    --cc=ruxandra.radulescu@nxp$(echo .)com \
    --cc=saeedm@mellanox$(echo .)com \
    --cc=sburla@marvell$(echo .)com \
    --cc=simon.horman@netronome$(echo .)com \
    --cc=vivien.didelot@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox