From: Jiri Pirko <jiri@resnulli•us>
To: Ido Schimmel <idosch@mellanox•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
Jiri Pirko <jiri@mellanox•com>, mlxsw <mlxsw@mellanox•com>
Subject: Re: [PATCH net 1/7] mlxsw: spectrum_switchdev: Add MDB entries in prepare phase
Date: Wed, 10 Apr 2019 15:39:44 +0200 [thread overview]
Message-ID: <20190410133944.GB2130@nanopsycho> (raw)
In-Reply-To: <20190410065758.21199-2-idosch@mellanox.com>
Wed, Apr 10, 2019 at 08:58:12AM CEST, idosch@mellanox•com wrote:
>The driver cannot guarantee in the prepare phase that it will be able to
>write an MDB entry to the device. In case the driver returned success
>during the prepare phase, but then failed to add the entry in the commit
>phase, a WARNING [1] will be generated by the switchdev core.
>
>Fix this by doing the work in the prepare phase instead.
>
>[1]
>[ 358.544486] swp12s0: Commit of object (id=2) failed.
>[ 358.550061] WARNING: CPU: 0 PID: 30 at net/switchdev/switchdev.c:281 switchdev_port_obj_add_now+0x9b/0xe0
>[ 358.560754] CPU: 0 PID: 30 Comm: kworker/0:1 Not tainted 5.0.0-custom-13382-gf2449babf221 #1350
>[ 358.570472] Hardware name: Mellanox Technologies Ltd. MSN2100-CB2FO/SA001017, BIOS 5.6.5 06/07/2016
>[ 358.580582] Workqueue: events switchdev_deferred_process_work
>[ 358.587001] RIP: 0010:switchdev_port_obj_add_now+0x9b/0xe0
>...
>[ 358.614109] RSP: 0018:ffffa6b900d6fe18 EFLAGS: 00010286
>[ 358.619943] RAX: 0000000000000000 RBX: ffff8b00797ff000 RCX: 0000000000000000
>[ 358.627912] RDX: ffff8b00b7a1d4c0 RSI: ffff8b00b7a152e8 RDI: ffff8b00b7a152e8
>[ 358.635881] RBP: ffff8b005c3f5bc0 R08: 000000000000022b R09: 0000000000000000
>[ 358.643850] R10: 0000000000000000 R11: ffffa6b900d6fcc8 R12: 0000000000000000
>[ 358.651819] R13: dead000000000100 R14: ffff8b00b65a23c0 R15: 0ffff8b00b7a2200
>[ 358.659790] FS: 0000000000000000(0000) GS:ffff8b00b7a00000(0000) knlGS:0000000000000000
>[ 358.668820] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>[ 358.675228] CR2: 00007f00aad90de0 CR3: 00000001ca80d000 CR4: 00000000001006f0
>[ 358.683188] Call Trace:
>[ 358.685918] switchdev_port_obj_add_deferred+0x13/0x60
>[ 358.691655] switchdev_deferred_process+0x6b/0xf0
>[ 358.696907] switchdev_deferred_process_work+0xa/0x10
>[ 358.702548] process_one_work+0x1f5/0x3f0
>[ 358.707022] worker_thread+0x28/0x3c0
>[ 358.711099] ? process_one_work+0x3f0/0x3f0
>[ 358.715768] kthread+0x10d/0x130
>[ 358.719369] ? __kthread_create_on_node+0x180/0x180
>[ 358.724815] ret_from_fork+0x35/0x40
>
>Fixes: 3a49b4fde2a1 ("mlxsw: Adding layer 2 multicast support")
>Signed-off-by: Ido Schimmel <idosch@mellanox•com>
>Reported-by: Alex Kushnarov <alexanderk@mellanox•com>
>Tested-by: Alex Kushnarov <alexanderk@mellanox•com>
Acked-by: Jiri Pirko <jiri@mellanox•com>
next prev parent reply other threads:[~2019-04-10 13:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 6:58 [PATCH net 0/7] mlxsw: Various fixes Ido Schimmel
2019-04-10 6:58 ` [PATCH net 1/7] mlxsw: spectrum_switchdev: Add MDB entries in prepare phase Ido Schimmel
2019-04-10 13:39 ` Jiri Pirko [this message]
2019-04-10 6:58 ` [PATCH net 2/7] mlxsw: core: Do not use WQ_MEM_RECLAIM for EMAD workqueue Ido Schimmel
2019-04-10 6:58 ` [PATCH net 3/7] mlxsw: core: Do not use WQ_MEM_RECLAIM for mlxsw ordered workqueue Ido Schimmel
2019-04-10 6:58 ` [PATCH net 4/7] mlxsw: core: Do not use WQ_MEM_RECLAIM for mlxsw workqueue Ido Schimmel
2019-04-10 6:58 ` [PATCH net 5/7] mlxsw: spectrum_router: Do not check VRF MAC address Ido Schimmel
2019-04-10 6:58 ` [PATCH net 6/7] selftests: mlxsw: Test VRF MAC vetoing Ido Schimmel
2019-04-10 6:58 ` [PATCH net 7/7] mlxsw: spectrum_buffers: Add a multicast pool for Spectrum-2 Ido Schimmel
2019-04-10 13:40 ` Jiri Pirko
2019-04-10 18:58 ` [PATCH net 0/7] mlxsw: Various fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410133944.GB2130@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox