From: Jiri Pirko <jiri@resnulli•us>
To: Ido Schimmel <idosch@mellanox•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
Jiri Pirko <jiri@mellanox•com>, mlxsw <mlxsw@mellanox•com>
Subject: Re: [PATCH net 7/7] mlxsw: spectrum_buffers: Add a multicast pool for Spectrum-2
Date: Wed, 10 Apr 2019 15:40:47 +0200 [thread overview]
Message-ID: <20190410134047.GC2130@nanopsycho> (raw)
In-Reply-To: <20190410065758.21199-8-idosch@mellanox.com>
Wed, Apr 10, 2019 at 08:58:17AM CEST, idosch@mellanox•com wrote:
>In Spectrum-1, when a multicast packet is admitted to the shared buffer
>it increases the quotas of all the ports and {port, TC} to which it is
>forwarded to.
>
>The above means that multicast packets are accounted multiple times in
>the shared buffer and can therefore cause the associated shared buffer
>pool to fill up very quickly.
>
>To work around this issue, commit e83c045e53d7 ("mlxsw:
>spectrum_buffers: Configure MC pool") added a dedicated multicast pool
>in which multicast packets are accounted.
>
>The issue is not present in Spectrum-2, but in order to be backward
>compatible with Spectrum-1, its default behavior is to allow a multicast
>packet to increase multiple egress quotas instead of one.
>
>Until the new (non-backward compatible) mode is supported, configure a
>dedicated multicast pool as in Spectrum-1.
>
>Fixes: fe099bf682ab ("mlxsw: spectrum_buffers: Add Spectrum-2 shared buffer configuration")
>Signed-off-by: Ido Schimmel <idosch@mellanox•com>
>Reviewed-by: Petr Machata <petrm@mellanox•com>
Acked-by: Jiri Pirko <jiri@mellanox•com>
next prev parent reply other threads:[~2019-04-10 13:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 6:58 [PATCH net 0/7] mlxsw: Various fixes Ido Schimmel
2019-04-10 6:58 ` [PATCH net 1/7] mlxsw: spectrum_switchdev: Add MDB entries in prepare phase Ido Schimmel
2019-04-10 13:39 ` Jiri Pirko
2019-04-10 6:58 ` [PATCH net 2/7] mlxsw: core: Do not use WQ_MEM_RECLAIM for EMAD workqueue Ido Schimmel
2019-04-10 6:58 ` [PATCH net 3/7] mlxsw: core: Do not use WQ_MEM_RECLAIM for mlxsw ordered workqueue Ido Schimmel
2019-04-10 6:58 ` [PATCH net 4/7] mlxsw: core: Do not use WQ_MEM_RECLAIM for mlxsw workqueue Ido Schimmel
2019-04-10 6:58 ` [PATCH net 5/7] mlxsw: spectrum_router: Do not check VRF MAC address Ido Schimmel
2019-04-10 6:58 ` [PATCH net 6/7] selftests: mlxsw: Test VRF MAC vetoing Ido Schimmel
2019-04-10 6:58 ` [PATCH net 7/7] mlxsw: spectrum_buffers: Add a multicast pool for Spectrum-2 Ido Schimmel
2019-04-10 13:40 ` Jiri Pirko [this message]
2019-04-10 18:58 ` [PATCH net 0/7] mlxsw: Various fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410134047.GC2130@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox