From: Andrew Lunn <andrew@lunn•ch>
To: Igor Russkikh <Igor.Russkikh@aquantia•com>
Cc: "David S . Miller" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Nikita Danilov <Nikita.Danilov@aquantia•com>,
Dmitry Bogdanov <Dmitry.Bogdanov@aquantia•com>,
Yana Esina <yana.esina@aquantia•com>
Subject: Re: [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for chip temperature
Date: Tue, 23 Apr 2019 21:17:58 +0200 [thread overview]
Message-ID: <20190423191758.GL28405@lunn.ch> (raw)
In-Reply-To: <869d56f1adaa7c16f067bfe4b2e8cd780a29beaf.1556024424.git.igor.russkikh@aquantia.com>
> +static u32 aq_hwmon_temp_config[] = {
> + HWMON_T_INPUT | HWMON_T_LABEL,
> + 0,
It would be nice to also have
HWMON_T_MAX | HWMON_T_MIN |
HWMON_T_CRIT | HWMON_T_LCRIT |
which the PHY probably has.
At gives some degree of context. A temperature on its own of say 65C
is hard to interpret. Is it too hot? But if we have a critical of 85C
and a max of 95C we know we are O.K.
Andrew
next prev parent reply other threads:[~2019-04-23 19:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 13:17 [PATCH v2 net-next 00/16] net: atlantic: Aquantia driver updates 2019-04 Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 01/16] net: aquantia: add infrastructure to readout chip temperature Igor Russkikh
2019-04-23 19:12 ` Andrew Lunn
2019-04-24 8:29 ` Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for " Igor Russkikh
2019-04-23 19:17 ` Andrew Lunn [this message]
2019-04-24 8:28 ` Igor Russkikh
2019-04-24 12:32 ` Andrew Lunn
2019-04-23 13:17 ` [PATCH v2 net-next 03/16] net: aquantia: add link interrupt fields Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 04/16] net: aquantia: link interrupt handling function Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 05/16] net: aquantia: create global service workqueue Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 06/16] net: aquantia: link status irq handling Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 07/16] net: aquantia: improve ifup link detection Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 08/16] net: aquantia: use macros for better visibility Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 09/16] net: aquantia: user correct MSI irq type Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 10/16] net: aquantia: introduce fwreq mutex Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 11/16] net: aquantia: extract timer cb into work job Igor Russkikh
2019-04-24 0:37 ` Jakub Kicinski
2019-04-24 8:31 ` Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 12/16] net: aquantia: wrap fw ops by mutex Igor Russkikh
2019-04-23 13:17 ` [PATCH v2 net-next 13/16] net: aquantia: fetch up to date statistics on ethtool request Igor Russkikh
2019-04-23 13:18 ` [PATCH v2 net-next 14/16] net: aquantia: get total counters from DMA block Igor Russkikh
2019-04-23 13:18 ` [PATCH v2 net-next 15/16] net: aquantia: fixups on 64bit dma counters Igor Russkikh
2019-04-23 13:18 ` [PATCH v2 net-next 16/16] net: aquantia: remove outdated device ids Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423191758.GL28405@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Dmitry.Bogdanov@aquantia$(echo .)com \
--cc=Igor.Russkikh@aquantia$(echo .)com \
--cc=Nikita.Danilov@aquantia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yana.esina@aquantia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox