* [PATCH net] ipv6: Default fib6_type to RTN_UNICAST when not set
@ 2019-06-19 17:50 David Ahern
2019-06-19 21:15 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: David Ahern @ 2019-06-19 17:50 UTC (permalink / raw)
To: davem; +Cc: netdev, David Ahern
From: David Ahern <dsahern@gmail•com>
A user reported that routes are getting installed with type 0 (RTN_UNSPEC)
where before the routes were RTN_UNICAST. One example is from accel-ppp
which apparently still uses the ioctl interface and does not set
rtmsg_type. Another is the netlink interface where ipv6 does not require
rtm_type to be set (v4 does). Prior to the commit in the Fixes tag the
ipv6 stack converted type 0 to RTN_UNICAST, so restore that behavior.
Fixes: e8478e80e5a7 ("net/ipv6: Save route type in rt6_info")
Signed-off-by: David Ahern <dsahern@gmail•com>
---
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 0f60eb3a2873..11ad62effd56 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3184,7 +3184,7 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg,
rt->fib6_table = table;
rt->fib6_metric = cfg->fc_metric;
- rt->fib6_type = cfg->fc_type;
+ rt->fib6_type = cfg->fc_type ? : RTN_UNICAST;
rt->fib6_flags = cfg->fc_flags & ~RTF_GATEWAY;
ipv6_addr_prefix(&rt->fib6_dst.addr, &cfg->fc_dst, cfg->fc_dst_len);
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net] ipv6: Default fib6_type to RTN_UNICAST when not set
2019-06-19 17:50 [PATCH net] ipv6: Default fib6_type to RTN_UNICAST when not set David Ahern
@ 2019-06-19 21:15 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2019-06-19 21:15 UTC (permalink / raw)
To: dsahern; +Cc: netdev, dsahern
From: David Ahern <dsahern@kernel•org>
Date: Wed, 19 Jun 2019 10:50:24 -0700
> From: David Ahern <dsahern@gmail•com>
>
> A user reported that routes are getting installed with type 0 (RTN_UNSPEC)
> where before the routes were RTN_UNICAST. One example is from accel-ppp
> which apparently still uses the ioctl interface and does not set
> rtmsg_type. Another is the netlink interface where ipv6 does not require
> rtm_type to be set (v4 does). Prior to the commit in the Fixes tag the
> ipv6 stack converted type 0 to RTN_UNICAST, so restore that behavior.
>
> Fixes: e8478e80e5a7 ("net/ipv6: Save route type in rt6_info")
> Signed-off-by: David Ahern <dsahern@gmail•com>
Applied and queued up for -stable, thanks David.
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <8dad6e3cf2e6cb0086b0a6f75ccdb44822a15001.camel@infinera.com>]
end of thread, other threads:[~2019-08-27 21:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-19 17:50 [PATCH net] ipv6: Default fib6_type to RTN_UNICAST when not set David Ahern
2019-06-19 21:15 ` David Miller
[not found] <8dad6e3cf2e6cb0086b0a6f75ccdb44822a15001.camel@infinera.com>
[not found] ` <20190827170729.GD21369@kroah.com>
2019-08-27 17:24 ` Joakim Tjernlund
2019-08-27 17:51 ` David Ahern
2019-08-27 21:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox