* [PATCH net-next] audit: Move audit_log_task declaration under CONFIG_AUDITSYSCALL
@ 2019-11-21 15:58 Jiri Olsa
2019-11-21 20:38 ` Daniel Borkmann
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Olsa @ 2019-11-21 15:58 UTC (permalink / raw)
To: David S. Miller
Cc: kbuild test robot, netdev, Steve Grubb, Alexei Starovoitov,
Daniel Borkmann
The 0-DAY found that audit_log_task is not declared under
CONFIG_AUDITSYSCALL which causes compilation error when
it is not defined:
kernel/bpf/syscall.o: In function `bpf_audit_prog.isra.30':
>> syscall.c:(.text+0x860): undefined reference to `audit_log_task'
Adding the audit_log_task declaration and stub within
CONFIG_AUDITSYSCALL ifdef.
Fixes: 91e6015b082b ("bpf: Emit audit messages upon successful prog load and unload")
Reported-by: kbuild test robot <lkp@intel•com>
Signed-off-by: Jiri Olsa <jolsa@kernel•org>
---
include/linux/audit.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/linux/audit.h b/include/linux/audit.h
index edd006f4597d..18925d924c73 100644
--- a/include/linux/audit.h
+++ b/include/linux/audit.h
@@ -159,7 +159,6 @@ extern void audit_log_key(struct audit_buffer *ab,
extern void audit_log_link_denied(const char *operation);
extern void audit_log_lost(const char *message);
-extern void audit_log_task(struct audit_buffer *ab);
extern int audit_log_task_context(struct audit_buffer *ab);
extern void audit_log_task_info(struct audit_buffer *ab);
@@ -220,8 +219,6 @@ static inline void audit_log_key(struct audit_buffer *ab, char *key)
{ }
static inline void audit_log_link_denied(const char *string)
{ }
-static inline void audit_log_task(struct audit_buffer *ab)
-{ }
static inline int audit_log_task_context(struct audit_buffer *ab)
{
return 0;
@@ -361,6 +358,8 @@ static inline void audit_ptrace(struct task_struct *t)
__audit_ptrace(t);
}
+extern void audit_log_task(struct audit_buffer *ab);
+
/* Private API (for audit.c only) */
extern void __audit_ipc_obj(struct kern_ipc_perm *ipcp);
extern void __audit_ipc_set_perm(unsigned long qbytes, uid_t uid, gid_t gid, umode_t mode);
@@ -648,6 +647,9 @@ static inline void audit_ntp_log(const struct audit_ntp_data *ad)
static inline void audit_ptrace(struct task_struct *t)
{ }
+
+static inline void audit_log_task(struct audit_buffer *ab)
+{ }
#define audit_n_rules 0
#define audit_signals 0
#endif /* CONFIG_AUDITSYSCALL */
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] audit: Move audit_log_task declaration under CONFIG_AUDITSYSCALL
2019-11-21 15:58 [PATCH net-next] audit: Move audit_log_task declaration under CONFIG_AUDITSYSCALL Jiri Olsa
@ 2019-11-21 20:38 ` Daniel Borkmann
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2019-11-21 20:38 UTC (permalink / raw)
To: Jiri Olsa, David S. Miller
Cc: kbuild test robot, netdev, Steve Grubb, Alexei Starovoitov
On 11/21/19 4:58 PM, Jiri Olsa wrote:
> The 0-DAY found that audit_log_task is not declared under
> CONFIG_AUDITSYSCALL which causes compilation error when
> it is not defined:
>
> kernel/bpf/syscall.o: In function `bpf_audit_prog.isra.30':
> >> syscall.c:(.text+0x860): undefined reference to `audit_log_task'
>
> Adding the audit_log_task declaration and stub within
> CONFIG_AUDITSYSCALL ifdef.
>
> Fixes: 91e6015b082b ("bpf: Emit audit messages upon successful prog load and unload")
> Reported-by: kbuild test robot <lkp@intel•com>
> Signed-off-by: Jiri Olsa <jolsa@kernel•org>
Acked-by: Daniel Borkmann <daniel@iogearbox•net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-21 20:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-21 15:58 [PATCH net-next] audit: Move audit_log_task declaration under CONFIG_AUDITSYSCALL Jiri Olsa
2019-11-21 20:38 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox