* [PATCH net-next] taprio: do not use BIT() in TCA_TAPRIO_ATTR_FLAG_* definitions
@ 2020-03-24 4:19 Eugene Syromiatnikov
2020-03-24 8:55 ` Vladimir Oltean
2020-03-27 3:08 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Eugene Syromiatnikov @ 2020-03-24 4:19 UTC (permalink / raw)
To: linux-kernel, netdev, David S. Miller, Vinicius Costa Gomes,
Jamal Hadi Salim, Cong Wang, Jiri Pirko
Cc: Vladimir Oltean, Voon Weifeng, Dmitry V. Levin
BIT() macro definition is internal to the Linux kernel and is not
to be used in UAPI headers; replace its usage with the _BITUL() macro
that is already used elsewhere in the header.
Cc: <stable@vger•kernel.org> # v5.4+
Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
Signed-off-by: Eugene Syromiatnikov <esyr@redhat•com>
---
include/uapi/linux/pkt_sched.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
index bbe791b..0e43f67 100644
--- a/include/uapi/linux/pkt_sched.h
+++ b/include/uapi/linux/pkt_sched.h
@@ -1197,8 +1197,8 @@ enum {
* [TCA_TAPRIO_ATTR_SCHED_ENTRY_INTERVAL]
*/
-#define TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST BIT(0)
-#define TCA_TAPRIO_ATTR_FLAG_FULL_OFFLOAD BIT(1)
+#define TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST _BITUL(0)
+#define TCA_TAPRIO_ATTR_FLAG_FULL_OFFLOAD _BITUL(1)
enum {
TCA_TAPRIO_ATTR_UNSPEC,
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] taprio: do not use BIT() in TCA_TAPRIO_ATTR_FLAG_* definitions
2020-03-24 4:19 [PATCH net-next] taprio: do not use BIT() in TCA_TAPRIO_ATTR_FLAG_* definitions Eugene Syromiatnikov
@ 2020-03-24 8:55 ` Vladimir Oltean
2020-03-27 3:08 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2020-03-24 8:55 UTC (permalink / raw)
To: Eugene Syromiatnikov
Cc: lkml, netdev, David S. Miller, Vinicius Costa Gomes,
Jamal Hadi Salim, Cong Wang, Jiri Pirko, Voon Weifeng,
Dmitry V. Levin
Hi Eugene,
On Tue, 24 Mar 2020 at 06:19, Eugene Syromiatnikov <esyr@redhat•com> wrote:
>
> BIT() macro definition is internal to the Linux kernel and is not
> to be used in UAPI headers; replace its usage with the _BITUL() macro
> that is already used elsewhere in the header.
>
> Cc: <stable@vger•kernel.org> # v5.4+
> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat•com>
> ---
I see this mirrors what was done in commit
commit 9903c8dc734265689d5770ff28c84a7228fe5890
Author: Vedang Patel <vedang.patel@intel•com>
Date: Tue Jun 25 15:07:13 2019 -0700
etf: Don't use BIT() in UAPI headers.
The BIT() macro isn't exported as part of the UAPI interface. So, the
compile-test to ensure they are self contained fails. So, use _BITUL()
instead.
Signed-off-by: Vedang Patel <vedang.patel@intel•com>
Signed-off-by: David S. Miller <davem@davemloft•net>
so
Acked-by: Vladimir Oltean <vladimir.oltean@nxp•com>
> include/uapi/linux/pkt_sched.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
> index bbe791b..0e43f67 100644
> --- a/include/uapi/linux/pkt_sched.h
> +++ b/include/uapi/linux/pkt_sched.h
> @@ -1197,8 +1197,8 @@ enum {
> * [TCA_TAPRIO_ATTR_SCHED_ENTRY_INTERVAL]
> */
>
> -#define TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST BIT(0)
> -#define TCA_TAPRIO_ATTR_FLAG_FULL_OFFLOAD BIT(1)
> +#define TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST _BITUL(0)
> +#define TCA_TAPRIO_ATTR_FLAG_FULL_OFFLOAD _BITUL(1)
>
> enum {
> TCA_TAPRIO_ATTR_UNSPEC,
> --
> 2.1.4
>
Regards,
-Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] taprio: do not use BIT() in TCA_TAPRIO_ATTR_FLAG_* definitions
2020-03-24 4:19 [PATCH net-next] taprio: do not use BIT() in TCA_TAPRIO_ATTR_FLAG_* definitions Eugene Syromiatnikov
2020-03-24 8:55 ` Vladimir Oltean
@ 2020-03-27 3:08 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-03-27 3:08 UTC (permalink / raw)
To: esyr
Cc: linux-kernel, netdev, vinicius.gomes, jhs, xiyou.wangcong, jiri,
olteanv, weifeng.voon, ldv
From: Eugene Syromiatnikov <esyr@redhat•com>
Date: Tue, 24 Mar 2020 05:19:20 +0100
> BIT() macro definition is internal to the Linux kernel and is not
> to be used in UAPI headers; replace its usage with the _BITUL() macro
> that is already used elsewhere in the header.
>
> Cc: <stable@vger•kernel.org> # v5.4+
> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat•com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-27 3:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-24 4:19 [PATCH net-next] taprio: do not use BIT() in TCA_TAPRIO_ATTR_FLAG_* definitions Eugene Syromiatnikov
2020-03-24 8:55 ` Vladimir Oltean
2020-03-27 3:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox