From: Andrew Lunn <andrew@lunn•ch>
To: Linus Walleij <linus.walleij@linaro•org>
Cc: Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
netdev@vger•kernel.org, DENG Qingfang <dqfext@gmail•com>,
Mauri Sandberg <sandberg@mailfence•com>
Subject: Re: [net-next PATCH 2/5 v2] net: dsa: rtl8366rb: Support the CPU DSA tag
Date: Thu, 18 Jun 2020 03:27:55 +0200 [thread overview]
Message-ID: <20200618012755.GC249144@lunn.ch> (raw)
In-Reply-To: <20200617083132.1847234-2-linus.walleij@linaro.org>
On Wed, Jun 17, 2020 at 10:31:29AM +0200, Linus Walleij wrote:
> This activates the support to use the CPU tag to properly
> direct ingress traffic to the right port.
>
> Bit 15 in register RTL8368RB_CPU_CTRL_REG can be set to
> 1 to disable the insertion of the CPU tag which is what
> the code currently does. The bit 15 define calls this
> setting RTL8368RB_CPU_INSTAG which is confusing since the
> iverse meaning is implied: programmers may think that
inverse
> setting this bit to 1 will *enable* inserting the tag
> rather than disablinbg it, so rename this setting in
disabling
> bit 15 to RTL8368RB_CPU_NO_TAG which is more to the
> point.
>
> After this e.g. ping works out-of-the-box with the
> RTL8366RB.
>
> Cc: DENG Qingfang <dqfext@gmail•com>
> Cc: Mauri Sandberg <sandberg@mailfence•com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro•org>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2020-06-18 1:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 8:31 [net-next PATCH 1/5 v2] net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag Linus Walleij
2020-06-17 8:31 ` [net-next PATCH 2/5 v2] net: dsa: rtl8366rb: Support the CPU DSA tag Linus Walleij
2020-06-18 1:27 ` Andrew Lunn [this message]
2020-06-17 8:31 ` [net-next PATCH 3/5 v2] net: dsa: rtl8366: Split out default VLAN config Linus Walleij
2020-06-18 1:29 ` Andrew Lunn
2020-06-17 8:31 ` [net-next PATCH 4/5 v2] net: dsa: rtl8366: VLAN 0 as disable tagging Linus Walleij
2020-06-18 1:31 ` Andrew Lunn
2020-06-18 3:23 ` Florian Fainelli
2020-07-05 23:04 ` Linus Walleij
2020-06-17 8:31 ` [net-next PATCH 5/5 v2] net: dsa: rtl8366: Use top VLANs for default Linus Walleij
2020-06-18 1:42 ` Andrew Lunn
2020-06-18 1:25 ` [net-next PATCH 1/5 v2] net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618012755.GC249144@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=dqfext@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sandberg@mailfence$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox