public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jesse Brandeburg <jesse.brandeburg@intel•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: "Ian Rogers" <irogers@google•com>,
	"Alexei Starovoitov" <ast@kernel•org>,
	"Daniel Borkmann" <daniel@iogearbox•net>,
	"Martin KaFai Lau" <kafai@fb•com>,
	"Song Liu" <songliubraving@fb•com>, "Yonghong Song" <yhs@fb•com>,
	"Andrii Nakryiko" <andrii@kernel•org>,
	"John Fastabend" <john.fastabend@gmail•com>,
	"KP Singh" <kpsingh@chromium•org>,
	"David S. Miller" <davem@davemloft•net>,
	"Igor Russkikh" <irusskikh@marvell•com>,
	"Mark Starovoytov" <mstarovoitov@marvell•com>,
	"Horatiu Vultur" <horatiu.vultur@microchip•com>,
	"Antoine Tenart" <antoine.tenart@bootlin•com>,
	"Toke Høiland-Jørgensen" <toke@redhat•com>,
	"Nikolay Aleksandrov" <nikolay@cumulusnetworks•com>,
	"Roopa Prabhu" <roopa@cumulusnetworks•com>,
	"Jiri Pirko" <jiri@mellanox•com>,
	"Vlad Buslov" <vladbu@mellanox•com>,
	"Ido Schimmel" <idosch@mellanox•com>,
	"Alexandre Cassen" <acassen@gmail•com>,
	linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
	bpf@vger•kernel.org
Subject: Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h
Date: Fri, 16 Oct 2020 17:34:58 -0700	[thread overview]
Message-ID: <20201016173458.00000597@intel.com> (raw)
In-Reply-To: <20201016143201.0c12c03b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Jakub Kicinski wrote:

> On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote:
> > > These are tested to be the latest as part of the tools/lib/bpf build.  
> > 
> > But you didn't mention why you're making these changes, and you're
> > removing a lot of comments without explaining why/where there might be
> > a replacement or why the comments are useless. I now see that you're
> > adding actual kdoc which is good, except for the part where
> > you don't put kdoc on all the structures.
> 
> Note that he's just syncing the uAPI headers to tools/
> 
> The source of the change is here:
> 
> 78a3ea555713 ("net: remove comments on struct rtnl_link_stats")
> 0db0c34cfbc9 ("net: tighten the definition of interface statistics")


Thanks Kuba, I'm not trying to be a hard ass, but the commit message
didn't say why he's making the change, and if I bisect back to this
and see "sync" as the commit message, I think I'd be stuck chasing
"sync to what?"

I guess that his changelog could just say what you said?

Proposed:
Sync the uAPI headers so that userspace and the kernel match. These
changes match the updates to the files in the tools directory that were
already updated by commits:
78a3ea555713 ("net: remove comments on struct rtnl_link_stats")
0db0c34cfbc9 ("net: tighten the definition of interface statistics")

     prev parent reply	other threads:[~2020-10-17  5:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 22:31 [PATCH 1/2] tools/include: Update if_link.h and netlink.h Ian Rogers
2020-10-15 22:31 ` [PATCH 2/2] tools/include: Add rtnetlink.h, id_addr.h and neighbour.h Ian Rogers
2020-10-16 21:23 ` [PATCH 1/2] tools/include: Update if_link.h and netlink.h Jesse Brandeburg
2020-10-16 21:32   ` Jakub Kicinski
2020-10-17  0:34     ` Jesse Brandeburg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201016173458.00000597@intel.com \
    --to=jesse.brandeburg@intel$(echo .)com \
    --cc=acassen@gmail$(echo .)com \
    --cc=andrii@kernel$(echo .)org \
    --cc=antoine.tenart@bootlin$(echo .)com \
    --cc=ast@kernel$(echo .)org \
    --cc=bpf@vger$(echo .)kernel.org \
    --cc=daniel@iogearbox$(echo .)net \
    --cc=davem@davemloft$(echo .)net \
    --cc=horatiu.vultur@microchip$(echo .)com \
    --cc=idosch@mellanox$(echo .)com \
    --cc=irogers@google$(echo .)com \
    --cc=irusskikh@marvell$(echo .)com \
    --cc=jiri@mellanox$(echo .)com \
    --cc=john.fastabend@gmail$(echo .)com \
    --cc=kafai@fb$(echo .)com \
    --cc=kpsingh@chromium$(echo .)org \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=mstarovoitov@marvell$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=nikolay@cumulusnetworks$(echo .)com \
    --cc=roopa@cumulusnetworks$(echo .)com \
    --cc=songliubraving@fb$(echo .)com \
    --cc=toke@redhat$(echo .)com \
    --cc=vladbu@mellanox$(echo .)com \
    --cc=yhs@fb$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox