From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Vladimir Oltean <olteanv@gmail•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, Florian Fainelli <f.fainelli@gmail•com>,
Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
Radu Pirea <radu-nicolae.pirea@oss•nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp•com>
Subject: Re: [PATCH net-next 3/3] net: phy: nxp-c45-tja11xx: enable MDIO write access to the master/slave registers
Date: Mon, 14 Jun 2021 13:29:19 +0100 [thread overview]
Message-ID: <20210614122919.GR22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210614121849.437119-4-olteanv@gmail.com>
On Mon, Jun 14, 2021 at 03:18:49PM +0300, Vladimir Oltean wrote:
> diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
> index 118b393b1cbb..b4dc112d4881 100644
> --- a/drivers/net/phy/nxp-c45-tja11xx.c
> +++ b/drivers/net/phy/nxp-c45-tja11xx.c
> @@ -1035,6 +1035,9 @@ static int nxp_c45_config_init(struct phy_device *phydev)
> return ret;
> }
>
> + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F8, 1);
> + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F9, 2);
I think this deserves a comment - especially since the code uses numeric
values here.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2021-06-14 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 12:18 [PATCH net-next 0/3] Fixes and improvements to TJA1103 PHY driver Vladimir Oltean
2021-06-14 12:18 ` [PATCH net-next 1/3] net: phy: nxp-c45-tja11xx: demote the "no PTP support" message to debug Vladimir Oltean
2021-06-14 12:29 ` Andrew Lunn
2021-06-14 12:18 ` [PATCH net-next 2/3] net: phy: nxp-c45-tja11xx: fix potential RX timestamp wraparound Vladimir Oltean
2021-06-14 12:18 ` [PATCH net-next 3/3] net: phy: nxp-c45-tja11xx: enable MDIO write access to the master/slave registers Vladimir Oltean
2021-06-14 12:29 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614122919.GR22278@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=radu-nicolae.pirea@oss$(echo .)nxp.com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox