* [PATCH net-next] net: mii: remove mii_lpa_mod_linkmode_lpa_sgmii()
@ 2022-01-27 16:33 Jakub Kicinski
2022-01-28 15:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2022-01-27 16:33 UTC (permalink / raw)
To: davem; +Cc: netdev, andrew, hkallweit1, linux, Jakub Kicinski,
Vladimir Oltean
Vladimir points out that since we removed mii_lpa_to_linkmode_lpa_sgmii(),
mii_lpa_mod_linkmode_lpa_sgmii() is also no longer called.
Suggested-by: Vladimir Oltean <olteanv@gmail•com>
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
include/linux/mii.h | 33 ---------------------------------
1 file changed, 33 deletions(-)
diff --git a/include/linux/mii.h b/include/linux/mii.h
index b8a1a17a87dd..5ee13083cec7 100644
--- a/include/linux/mii.h
+++ b/include/linux/mii.h
@@ -354,39 +354,6 @@ static inline u32 mii_adv_to_ethtool_adv_x(u32 adv)
return result;
}
-/**
- * mii_lpa_mod_linkmode_adv_sgmii
- * @lp_advertising: pointer to destination link mode.
- * @lpa: value of the MII_LPA register
- *
- * A small helper function that translates MII_LPA bits to
- * linkmode advertisement settings for SGMII.
- * Leaves other bits unchanged.
- */
-static inline void
-mii_lpa_mod_linkmode_lpa_sgmii(unsigned long *lp_advertising, u32 lpa)
-{
- u32 speed_duplex = lpa & LPA_SGMII_DPX_SPD_MASK;
-
- linkmode_mod_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT, lp_advertising,
- speed_duplex == LPA_SGMII_1000HALF);
-
- linkmode_mod_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, lp_advertising,
- speed_duplex == LPA_SGMII_1000FULL);
-
- linkmode_mod_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, lp_advertising,
- speed_duplex == LPA_SGMII_100HALF);
-
- linkmode_mod_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, lp_advertising,
- speed_duplex == LPA_SGMII_100FULL);
-
- linkmode_mod_bit(ETHTOOL_LINK_MODE_10baseT_Half_BIT, lp_advertising,
- speed_duplex == LPA_SGMII_10HALF);
-
- linkmode_mod_bit(ETHTOOL_LINK_MODE_10baseT_Full_BIT, lp_advertising,
- speed_duplex == LPA_SGMII_10FULL);
-}
-
/**
* mii_adv_mod_linkmode_adv_t
* @advertising:pointer to destination link mode.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: mii: remove mii_lpa_mod_linkmode_lpa_sgmii()
2022-01-27 16:33 [PATCH net-next] net: mii: remove mii_lpa_mod_linkmode_lpa_sgmii() Jakub Kicinski
@ 2022-01-28 15:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-28 15:10 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, andrew, hkallweit1, linux, olteanv
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft•net>:
On Thu, 27 Jan 2022 08:33:49 -0800 you wrote:
> Vladimir points out that since we removed mii_lpa_to_linkmode_lpa_sgmii(),
> mii_lpa_mod_linkmode_lpa_sgmii() is also no longer called.
>
> Suggested-by: Vladimir Oltean <olteanv@gmail•com>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
> ---
> include/linux/mii.h | 33 ---------------------------------
> 1 file changed, 33 deletions(-)
Here is the summary with links:
- [net-next] net: mii: remove mii_lpa_mod_linkmode_lpa_sgmii()
https://git.kernel.org/netdev/net-next/c/b5b3d10ef638
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-28 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-27 16:33 [PATCH net-next] net: mii: remove mii_lpa_mod_linkmode_lpa_sgmii() Jakub Kicinski
2022-01-28 15:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox