From: Gal Pressman <gal@nvidia•com>
To: Stephen Hemminger <stephen@networkplumber•org>,
David Ahern <dsahern@gmail•com>
Cc: <netdev@vger•kernel.org>, Gal Pressman <gal@nvidia•com>
Subject: [PATCH iproute2-next] tunnel: Fix missing space after local/remote print
Date: Wed, 9 Feb 2022 08:54:15 +0200 [thread overview]
Message-ID: <20220209065415.7068-1-gal@nvidia.com> (raw)
The cited commit removed the space after the local/remote tunnel print
and resulted in "broken" output:
gre remote 1.1.1.2local 1.1.1.1ttl inherit erspan_ver 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Fixes: 5632cf69ad59 ("tunnel: fix clang warning")
Signed-off-by: Gal Pressman <gal@nvidia•com>
---
v1->v2: https://lore.kernel.org/netdev/20220208144005.32401-1-gal@nvidia.com/
* Remove unneeded is_json_context()
---
ip/tunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ip/tunnel.c b/ip/tunnel.c
index f2632f43babf..224c81e42e9b 100644
--- a/ip/tunnel.c
+++ b/ip/tunnel.c
@@ -299,6 +299,7 @@ void tnl_print_endpoint(const char *name, const struct rtattr *rta, int family)
}
print_string_name_value(name, value);
+ print_string(PRINT_FP, NULL, " ", NULL);
}
void tnl_print_gre_flags(__u8 proto,
--
2.25.1
next reply other threads:[~2022-02-09 6:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 6:54 Gal Pressman [this message]
2022-02-10 18:10 ` [PATCH iproute2-next] tunnel: Fix missing space after local/remote print patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2022-02-08 14:40 Gal Pressman
2022-02-08 17:57 ` Stephen Hemminger
2022-02-09 6:51 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209065415.7068-1-gal@nvidia.com \
--to=gal@nvidia$(echo .)com \
--cc=dsahern@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox