public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Michael Guralnik <michaelgur@nvidia•com>
To: <netdev@vger•kernel.org>
Cc: <jiri@nvidia•com>, <ariela@nvidia•com>, <maorg@nvidia•com>,
	<saeedm@nvidia•com>, <kuba@kernel•org>, <moshe@nvidia•com>,
	Michael Guralnik <michaelgur@nvidia•com>
Subject: [RFC PATCH net-next 0/2] devlink: Add port stats
Date: Thu, 7 Apr 2022 11:40:48 +0300	[thread overview]
Message-ID: <20220407084050.184989-1-michaelgur@nvidia.com> (raw)

This patch set adds port statistics to the devlink port object.
It allows device drivers to dynamically attach and detach counters from a
devlink port object.

The approach of adding object-attached statistics is already supported for trap
with traffic statistics and for the dev object with reload statistics.
For the port object, this will allow the device driver to expose and dynamicly
control a set of metrics related to the port.
Currently we add support only for counters, but later API extensions can be made
to support histograms or configurable counters.

The statistics are exposed to the user with the port get command.

Example:
# devlink -s port show
pci/0000:00:0b.0/65535: type eth netdev eth1 flavour physical port 0 splittable false
  stats:
    counter1 235
    counter2 18

Michael Guralnik (2):
  devlink: Introduce stats to the port object
  devlink: Add statistics to port get

 include/net/devlink.h        |  28 +++++++++
 include/uapi/linux/devlink.h |   4 ++
 net/core/devlink.c           | 119 +++++++++++++++++++++++++++++++++++
 3 files changed, 151 insertions(+)

-- 
2.17.2


             reply	other threads:[~2022-04-07  8:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  8:40 Michael Guralnik [this message]
2022-04-07  8:40 ` [RFC PATCH net-next 1/2] devlink: Introduce stats to the port object Michael Guralnik
2022-04-07  8:40 ` [RFC PATCH net-next 2/2] devlink: Add statistics to port get Michael Guralnik
2022-04-08  3:16 ` [RFC PATCH net-next 0/2] devlink: Add port stats Jakub Kicinski
2022-04-11 10:28   ` Jiri Pirko
2022-04-11 17:49     ` Jakub Kicinski
2022-04-11 10:31   ` Jiri Pirko
2022-04-11 18:01     ` Jakub Kicinski
2022-04-12  8:16       ` Jiri Pirko
2022-04-12 15:34         ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407084050.184989-1-michaelgur@nvidia.com \
    --to=michaelgur@nvidia$(echo .)com \
    --cc=ariela@nvidia$(echo .)com \
    --cc=jiri@nvidia$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=maorg@nvidia$(echo .)com \
    --cc=moshe@nvidia$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=saeedm@nvidia$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox