From: Jakub Kicinski <kuba@kernel•org>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Michael Guralnik <michaelgur@nvidia•com>,
netdev@vger•kernel.org, jiri@nvidia•com, ariela@nvidia•com,
maorg@nvidia•com, saeedm@nvidia•com, moshe@nvidia•com
Subject: Re: [RFC PATCH net-next 0/2] devlink: Add port stats
Date: Tue, 12 Apr 2022 08:34:54 -0700 [thread overview]
Message-ID: <20220412083454.7b2a545d@kernel.org> (raw)
In-Reply-To: <YlU1Wrn0zPbYN6pE@nanopsycho>
On Tue, 12 Apr 2022 10:16:26 +0200 Jiri Pirko wrote:
> Mon, Apr 11, 2022 at 08:01:57PM CEST, kuba@kernel•org wrote:
> >> Wait, does all stats have to be well-defined? I mean, look at the
> >> ethtool stats. They are free-form strings too. Do you mean that in
> >> devlink, we can only have well-defines enum-based stats?
> >
> >That's my strong preference, yes.
> >
> >First, and obvious argument is that it make lazy coding less likely
> >(see devlink params).
> >
> >More importantly, tho, if your stats are not well defined - users don't
> >need to seem them. Really! If I can't draw a line between a statistic
> >and device behavior then keep that stat in the register dump, debugfs
>
> During the DaveM's-only era, there was quite strict policy against any
> debugfs usage. As far as I remember the claim was, find of define the
> proper api or do your debug things out-of-tree.
>
> Does that changed? I just want to make sure that we are now free to use
> debugfs for exposuse of debugging info as "odd vendor stats".
> Personally, I think it is good idea. I think that the rest of the kernel
> actually uses debugfs like that.
I think the policy is "it's fine as long as it's read-only".
Which could be a problem if you want to parametrize the counters.
But then again based on this RFC IDK if you do.
> >or /dev/null.
> >
> >That's why it's important that we talk about _what_ you're trying to
> >expose.
>
> Basically a mixture of quite generic things and very obscure device
> specific items.
prev parent reply other threads:[~2022-04-12 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 8:40 [RFC PATCH net-next 0/2] devlink: Add port stats Michael Guralnik
2022-04-07 8:40 ` [RFC PATCH net-next 1/2] devlink: Introduce stats to the port object Michael Guralnik
2022-04-07 8:40 ` [RFC PATCH net-next 2/2] devlink: Add statistics to port get Michael Guralnik
2022-04-08 3:16 ` [RFC PATCH net-next 0/2] devlink: Add port stats Jakub Kicinski
2022-04-11 10:28 ` Jiri Pirko
2022-04-11 17:49 ` Jakub Kicinski
2022-04-11 10:31 ` Jiri Pirko
2022-04-11 18:01 ` Jakub Kicinski
2022-04-12 8:16 ` Jiri Pirko
2022-04-12 15:34 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412083454.7b2a545d@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ariela@nvidia$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=maorg@nvidia$(echo .)com \
--cc=michaelgur@nvidia$(echo .)com \
--cc=moshe@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox