From: Lukas Wunner <lukas@wunner•de>
To: netdev@vger•kernel.org
Cc: Andrew Lunn <andrew@lunn•ch>
Subject: Re: [PATCH net-next v3 2/7] usbnet: smsc95xx: Don't clear read-only PHY interrupt
Date: Thu, 12 May 2022 13:57:30 +0200 [thread overview]
Message-ID: <20220512115730.GA4703@wunner.de> (raw)
In-Reply-To: <97d9528bb7fbee7313c5c6fb3a80346faaa32c13.1652343655.git.lukas@wunner.de>
On Thu, May 12, 2022 at 10:42:02AM +0200, Lukas Wunner wrote:
> Upon receiving data from the Interrupt Endpoint, the SMSC LAN95xx driver
> attempts to clear the signaled interrupts by writing "all ones" to the
> Interrupt Status Register.
>
> However the driver only ever enables a single type of interrupt, namely
> the PHY Interrupt. And according to page 119 of the LAN950x datasheet,
> its bit in the Interrupt Status Register is read-only. There's no other
> way to clear it than in a separate PHY register:
>
> https://www.microchip.com/content/dam/mchp/documents/UNG/ProductDocuments/DataSheets/LAN950x-Data-Sheet-DS00001875D.pdf
>
> Consequently, writing "all ones" to the Interrupt Status Register is
> pointless and can be dropped.
>
> Tested-by: Oleksij Rempel <o.rempel@pengutronix•de> # LAN9514/9512/9500
> Tested-by: Ferry Toth <fntoth@gmail•com> # LAN9514
> Signed-off-by: Lukas Wunner <lukas@wunner•de>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Forgot to add Andrew's R-b which he kindly provided here:
https://lore.kernel.org/netdev/YnGqtCDVHHpo%2FS+L@lunn.ch/
Let's see if patchwork picks the tag up if I add it like this.
My apologies for the inconvenience.
next prev parent reply other threads:[~2022-05-12 11:57 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 8:42 [PATCH net-next v3 0/7] Polling be gone on LAN95xx Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 1/7] usbnet: Run unregister_netdev() before unbind() again Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 2/7] usbnet: smsc95xx: Don't clear read-only PHY interrupt Lukas Wunner
2022-05-12 11:57 ` Lukas Wunner [this message]
2022-05-12 8:42 ` [PATCH net-next v3 3/7] usbnet: smsc95xx: Don't reset PHY behind PHY driver's back Lukas Wunner
2022-05-12 12:12 ` Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 4/7] usbnet: smsc95xx: Avoid link settings race on interrupt reception Lukas Wunner
2022-05-12 12:15 ` Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 5/7] usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling Lukas Wunner
2022-05-17 10:18 ` Marek Szyprowski
2022-05-19 19:08 ` Lukas Wunner
2022-05-19 21:22 ` Marek Szyprowski
2022-05-23 9:43 ` Lukas Wunner
2022-05-23 11:38 ` Marek Szyprowski
2022-05-23 12:34 ` Andrew Lunn
2022-05-23 13:47 ` Lukas Wunner
2022-05-24 0:52 ` Andrew Lunn
2022-05-24 1:08 ` Andrew Lunn
2022-05-24 6:16 ` Marek Szyprowski
2022-05-24 12:03 ` Andrew Lunn
2022-05-26 13:55 ` Lukas Wunner
2022-05-24 12:13 ` Lukas Wunner
2022-06-06 1:28 ` Andrew Lunn
2022-08-26 6:51 ` Marek Szyprowski
2022-08-26 7:19 ` Lukas Wunner
2022-08-26 7:41 ` Marek Szyprowski
2022-08-26 7:53 ` Lukas Wunner
2022-08-26 8:29 ` Marek Szyprowski
2022-08-29 11:40 ` Marek Szyprowski
2022-09-18 19:13 ` Lukas Wunner
2022-09-18 20:41 ` Florian Fainelli
2022-09-18 20:55 ` Lukas Wunner
2022-09-18 22:11 ` Florian Fainelli
2022-09-23 4:20 ` Lukas Wunner
2022-09-22 13:21 ` Marek Szyprowski
2022-05-12 8:42 ` [PATCH net-next v3 6/7] net: phy: smsc: Cache interrupt mask Lukas Wunner
2022-05-12 12:17 ` Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 7/7] net: phy: smsc: Cope with hot-removal in interrupt handler Lukas Wunner
2022-05-12 12:19 ` Lukas Wunner
2022-05-13 10:40 ` [PATCH net-next v3 0/7] Polling be gone on LAN95xx patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512115730.GA4703@wunner.de \
--to=lukas@wunner$(echo .)de \
--cc=andrew@lunn$(echo .)ch \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox