From: Jakub Kicinski <kuba@kernel•org>
To: Pablo Neira Ayuso <pablo@netfilter•org>
Cc: Florian Westphal <fw@strlen•de>,
Oliver Smith <osmith@sysmocom•de>,
netdev@vger•kernel.org, Harald Welte <laforge@gnumonks•org>
Subject: Re: regression: 'ctnetlink_dump_one_entry' defined but not used
Date: Thu, 19 May 2022 13:13:41 -0700 [thread overview]
Message-ID: <20220519131341.36c8b24e@kernel.org> (raw)
In-Reply-To: <20220519102100.GJ4316@breakpoint.cc>
On Thu, 19 May 2022 12:21:00 +0200 Florian Westphal wrote:
> Oliver Smith <osmith@sysmocom•de> wrote:
> > Hi Florian,
> >
> > since May 17 we see some automatic builds against net-next.git fail with:
> >
> > > net/netfilter/nf_conntrack_netlink.c:1717:12: error: 'ctnetlink_dump_one_entry' defined but not used [-Werror=unused-function]
> > > 1717 | static int ctnetlink_dump_one_entry(struct sk_buff *skb,
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Looks like this is a regression from your patch 8a75a2c17, I guess
> > ctnetlink_dump_one_entry needs #ifdef CONFIG_NF_CONNTRACK_EVENTS?
>
> Its fixed in nf-next.
Let's get it out to net-next, please, I'm carrying this patch locally
as well :(
next prev parent reply other threads:[~2022-05-19 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 9:06 regression: 'ctnetlink_dump_one_entry' defined but not used Oliver Smith
2022-05-19 10:21 ` Florian Westphal
2022-05-19 20:13 ` Jakub Kicinski [this message]
2022-05-19 20:31 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519131341.36c8b24e@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=fw@strlen$(echo .)de \
--cc=laforge@gnumonks$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=osmith@sysmocom$(echo .)de \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox