From: Rob Herring <robh@kernel•org>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>,
Mark Brown <broonie@kernel•org>,
Corentin Labbe <clabbe@baylibre•com>,
calvin.johnson@oss•nxp.com, davem@davemloft•net,
edumazet@google•com, hkallweit1@gmail•com,
jernej.skrabec@gmail•com, krzysztof.kozlowski+dt@linaro•org,
kuba@kernel•org, lgirdwood@gmail•com, linux@armlinux•org.uk,
pabeni@redhat•com, samuel@sholland•org, wens@csie•org,
devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-sunxi@lists•linux.dev,
netdev@vger•kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators
Date: Thu, 19 May 2022 15:17:59 -0500 [thread overview]
Message-ID: <20220519201759.GC2071376-robh@kernel.org> (raw)
In-Reply-To: <YoYw2lKbgCiDXP0A@lunn.ch>
On Thu, May 19, 2022 at 01:58:18PM +0200, Andrew Lunn wrote:
> On Thu, May 19, 2022 at 01:33:21PM +0200, Krzysztof Kozlowski wrote:
> > On 19/05/2022 13:31, Mark Brown wrote:
> > > On Thu, May 19, 2022 at 11:55:28AM +0200, Krzysztof Kozlowski wrote:
> > >> On 18/05/2022 22:09, Corentin Labbe wrote:
> > >
> > >>> + regulators:
> > >>> + description:
> > >>> + List of phandle to regulators needed for the PHY
> > >
> > >> I don't understand that... is your PHY defining the regulators or using
> > >> supplies? If it needs a regulator (as a supply), you need to document
> > >> supplies, using existing bindings.
> > >
> > > They're trying to have a generic driver which works with any random PHY
> > > so the binding has no idea what supplies it might need.
> >
> > OK, that makes sense, but then question is why not using existing
> > naming, so "supplies" and "supply-names"?
>
> I'm not saying it is not possible, but in general, the names are not
> interesting. All that is needed is that they are all on, or
> potentially all off to save power on shutdown. We don't care how many
> there are, or what order they are enabled.
>
> Ethernet PHY can have multiple supplies. For example there can be two
> digital voltages and one analogue. Most designs just hard wire them
> always on. It would not be unreasonable to have one GPIO which
> controls all three. Or there could be one GPIO for the two digital
> supplies, and one for the analogue. Or potentially, three GPIOs.
Again, it's not just supplies...
>
> Given all the different ways the board could be designed, i doubt any
> driver is going to want to control its supplies in an way other than
> all on, or all off. 802.3 clause 22 defines a standardized way to put
> a PHY into a low power mode. Using that one bit is much simpler than
> trying to figure out how a board is wired.
>
> However, the API/binding should be generic, usable for other use
> cases.
The binding should not be generic as I explained here and many times
before...
> Nobody has needed an API like this before, but it is not to say
> it might have other uses in the future. So maybe "supplies" and
> "supply-names" is useful, but we still need a way to enumerate them as
> a list without caring how many there are, or what their names are.
There's 2 standard patterns for how producer/consumer bindings work
There's how gpio and regulators are done and then there's the
foo/foo-names style. Regulators when with the former and we're not going
to do both.
You can still do what you want by retrieving all properties ending with
'-supply'. Not as easy to implement, but works for existing users.
Rob
next prev parent reply other threads:[~2022-05-19 20:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 20:09 [PATCH v2 0/5] arm64: add ethernet to orange pi 3 Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 1/5] regulator: Add of_get_regulator_from_list Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 2/5] regulator: Add regulator_bulk_get_all Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 3/5] phy: handle optional regulator for PHY Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators Corentin Labbe
2022-05-19 0:08 ` Rob Herring
2022-05-19 9:55 ` Krzysztof Kozlowski
2022-05-19 11:31 ` Mark Brown
2022-05-19 11:33 ` Krzysztof Kozlowski
2022-05-19 11:58 ` Andrew Lunn
2022-05-19 15:49 ` Mark Brown
2022-05-20 7:57 ` Krzysztof Kozlowski
2022-05-20 8:15 ` LABBE Corentin
2022-05-20 10:19 ` Krzysztof Kozlowski
2022-05-19 20:17 ` Rob Herring [this message]
2022-05-18 20:09 ` [PATCH v2 5/5] arm64: dts: allwinner: orange-pi-3: Enable ethernet Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519201759.GC2071376-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=broonie@kernel$(echo .)org \
--cc=calvin.johnson@oss$(echo .)nxp.com \
--cc=clabbe@baylibre$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=samuel@sholland$(echo .)org \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox