From: Mark Brown <broonie@kernel•org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>
Cc: Corentin Labbe <clabbe@baylibre•com>,
andrew@lunn•ch, calvin.johnson@oss•nxp.com, davem@davemloft•net,
edumazet@google•com, hkallweit1@gmail•com,
jernej.skrabec@gmail•com, krzysztof.kozlowski+dt@linaro•org,
kuba@kernel•org, lgirdwood@gmail•com, linux@armlinux•org.uk,
pabeni@redhat•com, robh+dt@kernel•org, samuel@sholland•org,
wens@csie•org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-sunxi@lists•linux.dev,
netdev@vger•kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators
Date: Thu, 19 May 2022 12:31:36 +0100 [thread overview]
Message-ID: <YoYqmAB3P7fNOSVG@sirena.org.uk> (raw)
In-Reply-To: <95f3f0a4-17e6-ec5f-6f2f-23a5a4993a44@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Thu, May 19, 2022 at 11:55:28AM +0200, Krzysztof Kozlowski wrote:
> On 18/05/2022 22:09, Corentin Labbe wrote:
> > + regulators:
> > + description:
> > + List of phandle to regulators needed for the PHY
> I don't understand that... is your PHY defining the regulators or using
> supplies? If it needs a regulator (as a supply), you need to document
> supplies, using existing bindings.
They're trying to have a generic driver which works with any random PHY
so the binding has no idea what supplies it might need.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-19 11:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 20:09 [PATCH v2 0/5] arm64: add ethernet to orange pi 3 Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 1/5] regulator: Add of_get_regulator_from_list Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 2/5] regulator: Add regulator_bulk_get_all Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 3/5] phy: handle optional regulator for PHY Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators Corentin Labbe
2022-05-19 0:08 ` Rob Herring
2022-05-19 9:55 ` Krzysztof Kozlowski
2022-05-19 11:31 ` Mark Brown [this message]
2022-05-19 11:33 ` Krzysztof Kozlowski
2022-05-19 11:58 ` Andrew Lunn
2022-05-19 15:49 ` Mark Brown
2022-05-20 7:57 ` Krzysztof Kozlowski
2022-05-20 8:15 ` LABBE Corentin
2022-05-20 10:19 ` Krzysztof Kozlowski
2022-05-19 20:17 ` Rob Herring
2022-05-18 20:09 ` [PATCH v2 5/5] arm64: dts: allwinner: orange-pi-3: Enable ethernet Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoYqmAB3P7fNOSVG@sirena.org.uk \
--to=broonie@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=calvin.johnson@oss$(echo .)nxp.com \
--cc=clabbe@baylibre$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=samuel@sholland$(echo .)org \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox